Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Sierra Compatibility for generate_cask_token #39106

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

qkdreyer
Copy link
Contributor

user@elcapitan ~ % sw_vers
ProductName:	Mac OS X
ProductVersion:	10.11.6
BuildVersion:	15G1510
user@elcapitan ~ % l /System/Library/Frameworks/Ruby.framework/Versions/Current
lrwxr-xr-x  1 root  wheel     3B Oct 21  2015 /System/Library/Frameworks/Ruby.framework/Versions/Current -> 2.0
user@sierra ~ % sw_vers
ProductName:	Mac OS X
ProductVersion:	10.12.6
BuildVersion:	16G29
user@sierra ~ % l /System/Library/Frameworks/Ruby.framework/Versions/Current
lrwxr-xr-x  1 root  wheel     3B Sep 22  2016 /System/Library/Frameworks/Ruby.framework/Versions/Current -> 2.0
user@highsierra ~ % sw_vers
ProductName:	Mac OS X
ProductVersion:	10.13
BuildVersion:	17A365
user@highsierra ~ % l /System/Library/Frameworks/Ruby.framework/Versions/Current
lrwxr-xr-x  1 root  wheel     3B 27 sep 14:20 /System/Library/Frameworks/Ruby.framework/Versions/Current -> 2.3

```
user@elcapitan ~ % sw_vers
ProductName:	Mac OS X
ProductVersion:	10.11.6
BuildVersion:	15G1510
user@elcapitan ~ % l /System/Library/Frameworks/Ruby.framework/Versions/Current
lrwxr-xr-x  1 root  wheel     3B Oct 21  2015 /System/Library/Frameworks/Ruby.framework/Versions/Current -> 2.0
```

```
user@sierra ~ % sw_vers
ProductName:	Mac OS X
ProductVersion:	10.12.6
BuildVersion:	16G29
user@sierra ~ % l /System/Library/Frameworks/Ruby.framework/Versions/Current
lrwxr-xr-x  1 root  wheel     3B Sep 22  2016 /System/Library/Frameworks/Ruby.framework/Versions/Current -> 2.0
```

```
user@highsierra ~ % sw_vers
ProductName:	Mac OS X
ProductVersion:	10.13
BuildVersion:	17A365
user@highsierra ~ % l /System/Library/Frameworks/Ruby.framework/Versions/Current
lrwxr-xr-x  1 root  wheel     3B 27 sep 14:20 /System/Library/Frameworks/Ruby.framework/Versions/Current -> 2.3
```
@reitermarkus
Copy link
Member

reitermarkus commented Sep 29, 2017

This makes me wonder which of the scripts in developer/bin are actually still useful. Pretty sure we don't need irregular_cask_whitespace anymore since we have brew cask style.

@caskroom/maintainers?

@commitay
Copy link
Contributor

commitay commented Sep 29, 2017

Agree that we don't need irregular_cask_whitespace.

I think cask_switch_https would be (partially) replaced by #25403 (HTTPS audit check.)

All of the other scripts are still useful.

@miccal miccal merged commit bce21be into Homebrew:master Sep 29, 2017
@vitorgalvao
Copy link
Member

project_stats and the_long_tail can also get the boot.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants