Fix Picturelife app link

[jeanregisser]

The name of the app in the dmg changed.
Here's the fixed app name.

Cheers

[nanoxd]

@rolandwalker @vitorgalvao @fanquake Should we switch the name of the cask in this case? The download dmg is named Picturelife and the app is Smartloader.app

[jeanregisser]

I believe people interested by the picturelife app will most likely look for picturelife.

Given that they also have a lightroom plugin (see https://picturelife.com/download),
maybe a good solution would be to name it picturelife-smartloader.

What do you think?

[rolandwalker]

If upstream changed the app name, the Cask name should also change, following the app name, per the docs. Predictability is important here. For example, it keeps people from wasting effort on duplicate submissions.

@jeanregisser to help people find Casks (as there are now so many of them) we are adding a tags stanza in #4953. The first tag to be supported is :vendor. So in this case we could add

  tags :vendor => 'Picturelife'

I intend for brew cask search to be able to search all of the following:

• Cask names
• artifact names (the .app name in this case)
• tags

[jeanregisser]

Ok, I've also updated the cask name.
The vendor tag will be a nice solution to this problem.

[vitorgalvao]

Thank you. Could you please squash your commits?

[jeanregisser]

Sure, done!

[vitorgalvao]

Thank you.

[radeksimko]

Same situation here as with keyremap4macbook/Karabiner: #5282 (comment)

It may cause issues to users who already installed the cask as picturelife - effectively prevent uninstallation.

btw. @rolandwalker is apparently already working to solve this issue

[rolandwalker]

Yes, after #3066 we can uninstall based on the old definition even though it was deleted (though it doesn't track renames).

#3066 is waiting on #4688, though we are pretty far along at this point.