Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass link update #540

Merged
merged 14 commits into from
Jun 18, 2013
Merged

Mass link update #540

merged 14 commits into from
Jun 18, 2013

Conversation

nanoxd
Copy link
Contributor

@nanoxd nanoxd commented Jun 18, 2013

Worked on A-L to add links. I will be submitting additional PR for app updates and such.

Thanks!

@vitorgalvao
Copy link
Member

Thank you for this, but why did you change DiskInventoryX’s url? The other one seems to work fine, and having a cask always fetch the latest version is preferable.

@nanoxd
Copy link
Contributor Author

nanoxd commented Jun 18, 2013

My mistake, I thought it was preferable to have a versioned application to make implementing a brew cask upgrade work. I'll revert the commit to the original version.

@vitorgalvao
Copy link
Member

Does the app auto-update? If it does, then having the latest is definitely preferable; if it does not, then it’s a matter for discussing (it’s certainly easier to maintain, though).

@nanoxd
Copy link
Contributor Author

nanoxd commented Jun 18, 2013

The app does not auto update. It does not use the Sparkle framework.

On Tue, Jun 18, 2013 at 5:02 AM, Vítor Galvão notifications@github.comwrote:

Does the app auto-update? If it does, then having the latest is definitely
preferable; if it does not, then it’s a matter for discussinghttps://github.com//issues/309(it’s certainly easier to maintain, though).


Reply to this email directly or view it on GitHubhttps://github.com//pull/540#issuecomment-19606682
.

@vitorgalvao
Copy link
Member

Does it, however, warn you about the update (making you then go to the website to download), like Calibre does?

@nanoxd
Copy link
Contributor Author

nanoxd commented Jun 18, 2013

Not as far as I know of.

On Tue, Jun 18, 2013 at 5:06 AM, Vítor Galvão notifications@github.comwrote:

Does it, however, warn you about the update (making you then go to the
website to download), like Calibre does?


Reply to this email directly or view it on GitHubhttps://github.com//pull/540#issuecomment-19606880
.

vitorgalvao added a commit that referenced this pull request Jun 18, 2013
@vitorgalvao vitorgalvao merged commit 6a6d17a into Homebrew:master Jun 18, 2013
@nanoxd nanoxd deleted the MassLinkUpdate branch June 18, 2013 18:10
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants