Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI utility Iloc #5874

Merged
merged 1 commit into from
Aug 23, 2014
Merged

add CLI utility Iloc #5874

merged 1 commit into from
Aug 23, 2014

Conversation

rolandwalker
Copy link
Contributor

No description provided.

@rolandwalker
Copy link
Contributor Author

@caskroom/maintainers, esp @vitorgalvao, I've been thinking about naming executable-binary-only Casks with a prefix as in this PR, cli-iloc.rb.

Thoughts?

@federicobond
Copy link
Contributor

I think it would be a bit awkward for many casks. For example, should haskell-platform be named cli-haskell-platform if it was added today?

@vitorgalvao
Copy link
Member

@federicobond No, because haskell-platform uses install, not binary. @rolandwalker is referring to cases where the casks consists only of linked CLI tools (the ones that use binary exclusively).

Regarding the issue’s question, I have no strong opinion either way, but I do think some separation could be beneficial. If we go the suffix route, however, they should perhaps be the same (either binary or cli in both the name and the cask).

@rolandwalker
Copy link
Contributor Author

@vitorgalvao you are right, that's what I was thinking. But after @federicobond's question I have to ask myself if that would be confusing to a user. A user shouldn't have to know or care what we did inside the Cask.

So, let's broaden the question to say yes, all non-GUI apps would be prefixed "cli-", even cli-haskell-platform. Is that stupid? It might be.

I'm pretty certain it would be a good idea to add a consistent prefix on screensavers, input methods, and others that install into ~/Library and are not apps. For CLI Casks I am not so sure.

@federicobond
Copy link
Contributor

Thanks for the clarifications @vitorgalvao and @rolandwalker. I don't think prefixing all non-GUI apps is a good idea. It would probably confuse many users and contributors. I'm definitely open to doing this with more specific kinds of software though, such as screensavers and colorpickers, as @rolandwalker suggested.

@vitorgalvao
Copy link
Member

I don't think prefixing all non-GUI apps is a good idea. It would probably confuse many users and contributors. I'm definitely open to doing this with more specific kinds of software though, such as screensavers and colorpickers

I agree in full.

@rolandwalker
Copy link
Contributor Author

OK. Clearly decided against. I will update this PR without the prefix.

rolandwalker added a commit that referenced this pull request Aug 23, 2014
@rolandwalker rolandwalker merged commit fc7f49f into Homebrew:master Aug 23, 2014
@rolandwalker rolandwalker deleted the add_iloc branch August 23, 2014 15:01
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants