DSL: add artifact stanza
#6225
Merged
DSL: add artifact stanza
#6225
+96
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the `link` stanza in the DSL is a mistake: it will be confusing when combined with the ability to install by copying. This PR retires `link` completely, and adds a generic artifact stanza called `artifact`. (`link` is removed from the docs, but will still work for compatibility during transition.) This only affects one current Cask (dwarf-fortress.rb), and that Cask may be changed to use `suite` in the future.
|
As this only affects 1 or possibly zero Casks, and does not change backward-compatibility, at least for the moment, I am comfortable merging this immediately for release. |
rolandwalker
added a commit
that referenced
this pull request
Sep 17, 2014
DSL: add `artifact` stanza
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the
linkstanza in the DSL is a mistake: it will beconfusing when combined with the ability to install by copying.
This PR retires
linkcompletely, and adds a generic artifactstanza called
artifact. (linkis removed from the docs, butwill still work for compatibility during transition.)
This only affects one current Cask (dwarf-fortress.rb), and that
Cask may be changed to use
suitein the future.