Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testflight 320 #6761

Closed
wants to merge 1 commit into from
Closed

testflight 320 #6761

wants to merge 1 commit into from

Conversation

exherb
Copy link
Contributor

@exherb exherb commented Oct 18, 2014

No description provided.

@rolandwalker
Copy link
Contributor

Thanks!

Testing the new URL, I do not get version "320", but the same as the old URL: version 1.0_beta313.

@exherb
Copy link
Contributor Author

exherb commented Oct 18, 2014

Sorry, the version ("320') was extracted from CFBundleVersion at Info.plist of the newest testflight.app. I thought it's better for sparkle upgrade check in the future.

@exherb exherb closed this Oct 18, 2014
@exherb exherb deleted the testflight-320 branch October 18, 2014 11:16
@rolandwalker
Copy link
Contributor

Ah, yes, @exherb that is excellent thinking as well.

We have only recently added the :sha256 key to the appcast stanza (#6680, #6686). The next step will be to detect when the checksum changes, meaning that there is a new version.

Then we have to add code parse the appcast itself. Per this authoritative comment, sparkle is using the "320" number you proposed as its way to track the versioning (sparkle:version in the XML). But sparkle:shortVersionString is what is presented to the user.

In this case sparkle:shortVersionString is a yet-different value: "1.0".

I'm not sure how we will end up resolving this, because Casks ought to stay as simple as possible. We added the :latest_version key to appcast for some of this, but have left it undocumented so far — in part because I realized that :latest_version is easy to confuse with the already-existing version :latest.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants