repair how to create new cask #95740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
reviewed
Dec 17, 2020
doc/development/adding_a_cask.md
Outdated
| @@ -97,7 +97,7 @@ If the `generate_cask_token` script does not work for you, see [Cask Token Detai | |||
| Once you know the token, create your Cask with the handy-dandy `brew create --cask` command: | |||
|
|
|||
| ```bash | |||
| $ brew create --cask my-new-cask | |||
| $ brew create --cask my-new-cask-url --set-name my-new-cask | |||
There was a problem hiding this comment.
This might be clearer since the two values look less alike.
Suggested change
| $ brew create --cask my-new-cask-url --set-name my-new-cask | |
| $ brew create --cask cask-download-url --set-name my-new-cask |
hyuraku
force-pushed
the
repair-how-to-create-cask
branch
from
27c1463
to
a859220
Compare
hyuraku
force-pushed
the
repair-how-to-create-cask
branch
from
a859220
to
b1aa4f2
Compare
vitorgalvao
approved these changes
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew audit --cask {{cask_file}}is error-free.brew style --fix {{cask_file}}reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask {{cask_file}}worked successfully.brew install --cask {{cask_file}}worked successfully.brew uninstall --cask {{cask_file}}worked successfully.repair how to create new cask because of Homebrew/discussions#301