Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zap stanza for macspice #97056

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Added zap stanza for macspice #97056

merged 1 commit into from
Dec 30, 2020

Conversation

adithyasunil26
Copy link
Contributor

@adithyasunil26 adithyasunil26 commented Dec 29, 2020

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@miccal
Copy link
Member

miccal commented Dec 30, 2020

Thank you @adithyasunil26.

@miccal miccal merged commit 7cfffcc into Homebrew:master Dec 30, 2020
@adithyasunil26 adithyasunil26 deleted the macspice-zap branch December 30, 2020 10:37
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants