Merge pull request #191393 from Homebrew/xcode-reason

macvim mlx openjdk v8: add comment for `xcode` dependency
Homebrew · Sep 20, 2024 · 3ca65aa · 3ca65aa
2 parents 25798a5 + 04a8509
commit 3ca65aa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Formula/m/macvim.rb b/Formula/m/macvim.rb
@@ -32,7 +32,7 @@ class Macvim < Formula
 
   depends_on "gettext" => :build
   depends_on "libsodium" => :build
-  depends_on xcode: :build
+  depends_on xcode: :build # for xcodebuild
   depends_on "cscope"
   depends_on "lua"
   depends_on :macos

diff --git a/Formula/m/mlx.rb b/Formula/m/mlx.rb
@@ -25,7 +25,7 @@ class Mlx < Formula
   depends_on "python@3.12"
 
   on_arm do
-    depends_on xcode: ["15.0", :build]
+    depends_on xcode: ["15.0", :build] # for metal
   end
 
   on_intel do

diff --git a/Formula/o/openjdk.rb b/Formula/o/openjdk.rb
@@ -24,7 +24,7 @@ class Openjdk < Formula
 
   depends_on "autoconf" => :build
   depends_on "pkg-config" => :build
-  depends_on xcode: :build
+  depends_on xcode: :build # for metal
   depends_on "freetype"
   depends_on "giflib"
   depends_on "harfbuzz"

diff --git a/Formula/v/v8.rb b/Formula/v/v8.rb
@@ -34,7 +34,7 @@ class V8 < Formula
   end
 
   depends_on "ninja" => :build
-  depends_on xcode: ["10.0", :build] # required by v8
+  depends_on xcode: ["10.0", :build] # for xcodebuild, min version required by v8
 
   uses_from_macos "python" => :build