-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.9 Migration #62201
Comments
@Rylan12 can I pick this one? Please assign to me! |
@mayank thanks for your interest! Please feel free to work on this! This is too big of a project for one person to tackle on their own, but feel free to open a PR to update one or a few formulae. |
@Rylan12 I need to install all the formulas on mac? Is there anything like docker for this? |
There are 234 formulas that are independent: they depend on python@3.8 only directly, they have not reverse dependencies. I will deal with those first. |
@LSmith-Zenoscave and @mayank, this is not an issue that will be closed with one PR that updates all 400 formulae. The best way to do it is just to make a few PRs, each with one formula. Take a look at some of the PRs that have been made so far if you need a model for what we're looking for. If you're not already a Homebrew user this probably isn't a great issue for you. If you want to get more involved, though, feel free to check out some of the links I've added above for information about how to get set up. |
@fxcoudert: can you post the list of independent formulae (maybe link a gist?) so others can help out with those? |
FYI to anyone looking to help out here: The current Edit: I've started a fix in Homebrew/brew#8873 |
The list of independent formulas is below. If you don't mind, I'm happy to open PRs for all of them once There are plenty of other small "clusters" of formulas that can be migrated and where crowd-sourcing will be necessary.
|
Can you share how you came up with those numbers? I found a similar list but with 144. Perhaps I had some missed? edit made to adjust correction in my findings (forgot quote in a grep) |
|
I'm not really sure if this is connected, but could you have a look at Homebrew/discussions#37 and check whether upgrading to Python 3.9 broke |
Closes #62458. Signed-off-by: Rylan Polster <rslpolster@gmail.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
There's a label, and help is welcome on any relevant PR. I don't think there is much use for this meta-issue, maybe we should close it? |
I missed the label... Thanks! |
Are we definitely going to do the mass migration in #62560? If so, yeah I think this can be closed. If that's not going to work, there are still almost 200 formulae to be migrated so it might be worth keeping open in that case. |
Sounds like some of This may be controversial, but I hope this is complete before 3.10 is released. |
I wanna ask a dumb question: is it OK to upgrade |
This question is best asked on https://github.com/Homebrew/discussions/discussions, but yes you can update your own alias if you want to. |
Also part of the migration are test and audit failures that should be investigated and fixed: 10.15
10.14
10.13
|
I don't know what is the source of problem (migrating to py39, brew bug/feature or something else), but as for newly (from scratch) installed homebrew and python@3.9 on it:
There is no $(brew --prefix)/opt/python/ directory
No, there is no /usr/local/bin/python3
I don't know how to work with this "python3". |
@tieugene the |
I've been trying to reinstall mpv from source so as to get the app bundle for macOS, similarly to the closed and now locked "Missing mpv.app bundle #46532", but keep getting an error which I believe has something to do with python but I can't figure out what. Can anyone shed some light? Wasn't sure if to create a separate issue link to error text from terminal - https://pastebin.pl/view/a5a1e0d0 |
You should ask the mpv developers, homebrew doesn't provide support for modified builds. |
@hjmallon please open a new issue and provide all information requested, so we can help you |
@Raptoaaah please open a new issue and provide all information requested, so we can help you |
At this point we have migrated all the main Python formula to python 3.9. I am closing this tracking issue, as it mostly attracts bug reports (for which we prefer people to file new issues). Any help with the remaining PRs is welcome, at least in reporting bugs to upstream so they get fixed at some point. |
Python 3.9 has been released and added to homebrew-core!
Currently, there are 42 formulae in homebrew-core that depend on
python@3.8
. The next step in the migration process is to switch as many formulae as possible to depend on the newpython@3.9
formula.See #62201 (comment) for a list of formulae to be upgraded.
No need to ask before working on this. If there's a formula that you can update, go ahead and open a PR and we'll get to it as soon as we can!
This is a great first issue to work on if you're new to Homebrew and if you're participating in Hacktoberfest, this is a great way to knock out some genuine PRs that will be greatly appreciated!
Here are the basic steps to migrate a formula to Python 3.9:
depends_on "python@3.8"
todepends_on "python@3.9"
python@3.8
topython@3.9
revision 1
(if the formula already has a revision, increment the number by one)brew install -s <formula>
,brew test <formula>
andbrew audit --strict <formula>
<formula>: migrate to python@3.9
If you're a new contributor and want to help out, make sure to read our countributing guidelines and check out How To Open a Homebrew Pull Request in our documentation
The text was updated successfully, but these errors were encountered: