Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

julia 1.8.0 #100404

Closed
wants to merge 4 commits into from
Closed

julia 1.8.0 #100404

wants to merge 4 commits into from

Conversation

fxcoudert
Copy link
Member

Following up on an earlier attempt at #96194

@fxcoudert fxcoudert added do not merge prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies labels Apr 29, 2022
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 29, 2022
This was referenced Apr 29, 2022
Closed
Closed
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 30, 2022
@bayandin bayandin added the long build Set a long timeout for formula testing label May 1, 2022
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 3, 2022
@fxcoudert fxcoudert removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 3, 2022
@fxcoudert fxcoudert force-pushed the julia branch 2 times, most recently from 2820016 to 7ac57f0 Compare May 30, 2022 00:01
@fxcoudert fxcoudert changed the title julia: build on ARM and test 1.8.0-beta3 julia: build on ARM and test 1.8.0-rc1 May 30, 2022
@fxcoudert fxcoudert added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 30, 2022
@iMichka iMichka removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 30, 2022
@fxcoudert
Copy link
Member Author

Builds fine on macOS Intel and ARM! But a Linux-only error…

@fxcoudert
Copy link
Member Author

On Linux, libllvmcalltest.so is installed but not libLLVM.so — while on macOS we have both dylibs installed.

@fxcoudert fxcoudert added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 10, 2022
@fxcoudert
Copy link
Member Author

I thought I had fixed linux, but:

==>/home/linuxbrew/.linuxbrew/Cellar/julia/1.8.0-rc1/bin/julia --startup-file=no --history-file=no --project=/tmp/julia-test-20220610-105332-1p83ew --procs 2 --print '2 + 2'
  Segmentation fault (core dumped)

@fxcoudert fxcoudert removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 1, 2022
@fxcoudert
Copy link
Member Author

  • Rebasing after the merge of 1.7.3
  • Let it use its own (patched) libunwind on linux, otherwise it is broken

@github-actions github-actions bot removed the stale No recent activity label Jul 1, 2022
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 9, 2022
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 9, 2022
carlocab
carlocab reviewed Jul 9, 2022
View reviewed changes
Formula/julia.rb
Comment on lines -107 to -122
USE_SYSTEM_LLVM=1
USE_SYSTEM_LIBUNWIND=1
Copy link
Member

@carlocab carlocab Jul 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep these lines as

       USE_SYSTEM_LLVM=0
       USE_SYSTEM_LIBUNWIND=0

(or whatever it is make considers false-y) to make intent clearer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formula is long enough already, I think

@chenrui333 chenrui333 removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 9, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 31, 2022
@fxcoudert fxcoudert removed the stale No recent activity label Jul 31, 2022
@carlocab
Copy link
Member

Released https://github.com/JuliaLang/julia/releases/tag/v1.8.0.

@carlocab carlocab changed the title julia: build on ARM and test 1.8.0-rc2 julia 1.8.0 Aug 17, 2022
@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle perl Perl use is a significant feature of the PR or issue and removed automerge-skip `brew pr-automerge` will skip this pull request labels Aug 17, 2022
@fxcoudert fxcoudert added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed do not merge prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies labels Aug 17, 2022
@fxcoudert
Copy link
Member Author

So, julia 1.8.0 has a code signing bug: JuliaLang/julia#44502 (comment)
But I do not think Homebrew will be affected, because we re-sign the libraries when we pour bottles.

@carlocab
Copy link
Member

So, julia 1.8.0 has a code signing bug: JuliaLang/julia#44502 (comment)
But I do not think Homebrew will be affected, because we re-sign the libraries when we pour bottles.

Probably from patching binaries without re-signing them.

The GCC 12 patch fails to apply. Let's try to build without it...

@fxcoudert
Copy link
Member Author

@carlocab the patch for GCC 12 is related to JuliaLang/julia#44829
I think it was patched, then reversed (JuliaLang/julia@3a2eb39) then fixed again in some other way. It should be dropped for 1.8.0 release, as I understand things.

@carlocab
julia: drop GCC 12 patch
93d293e 
It fails to apply.
@fxcoudert
Copy link
Member Author

Probably from patching binaries without re-signing them.

Yes. I reported it in March, but the fix was never backported to the 1.8 branch 😢

cho-m
cho-m reviewed Aug 18, 2022
View reviewed changes
Formula/julia.rb Outdated Show resolved Hide resolved
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 18, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@fxcoudert fxcoudert deleted the julia branch August 18, 2022 13:46
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cho-m cho-m cho-m left review comments

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing no ARM bottle Formula has no ARM bottle outdated PR was locked due to age perl Perl use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fxcoudert @carlocab @BrewTestBot @cho-m @bayandin @chenrui333 @iMichka