Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcdf 4.9.0 #106520

Closed
wants to merge 3 commits into from
Closed

netcdf 4.9.0 #106520

wants to merge 3 commits into from

Conversation

owine
Copy link
Contributor

@owine owine commented Jul 25, 2022

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jul 25, 2022
@SMillerDev
Copy link
Member

Fortran resource needs updating

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 25, 2022
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 25, 2022
@SMillerDev
Copy link
Member

   duplicate symbol '_NCJnew' in:
      CMakeFiles/nczhdf5filters.dir/NCZhdf5filters.c.o
      ../liblib/libnetcdf.a(ncjson.c.o)
  duplicate symbol '_NCJcvt' in:
      CMakeFiles/nczhdf5filters.dir/NCZhdf5filters.c.o
      ../liblib/libnetcdf.a(ncjson.c.o)
  duplicate symbol '_NCJdictget' in:
      CMakeFiles/nczhdf5filters.dir/NCZhdf5filters.c.o
      ../liblib/libnetcdf.a(ncjson.c.o)
  duplicate symbol '_NCJnewstringn' in:
      CMakeFiles/nczhdf5filters.dir/NCZhdf5filters.c.o
      ../liblib/libnetcdf.a(ncjson.c.o)
  duplicate symbol '_NCJreclaim' in:
      CMakeFiles/nczhdf5filters.dir/NCZhdf5filters.c.o
      ../liblib/libnetcdf.a(ncjson.c.o)
  duplicate symbol '_NCJnewstring' in:
      CMakeFiles/nczhdf5filters.dir/NCZhdf5filters.c.o
      ../liblib/libnetcdf.a(ncjson.c.o)
  duplicate symbol '_NCJparse' in:
      CMakeFiles/nczhdf5filters.dir/NCZhdf5filters.c.o
      ../liblib/libnetcdf.a(ncjson.c.o)
  ld: 7 duplicate symbols for architecture arm64

@carlocab
Copy link
Member

No clue about the build error, but it looks like we've been really bad at keeping these resources updated. It may be better to ship them as separate formulae.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 30, 2022
@carlocab carlocab removed the stale No recent activity label Jul 30, 2022
@carlocab
Copy link
Member

Will introduce a merge conflict at #106755.

@carlocab carlocab added do not merge in progress Stale bot should stay away labels Jul 30, 2022
@carlocab carlocab self-requested a review July 30, 2022 15:07
@danielnachun danielnachun mentioned this pull request Sep 13, 2022
6 tasks
@jonchang
Copy link
Contributor

jonchang commented Oct 3, 2022

Merged in #112159.

@jonchang jonchang closed this Oct 3, 2022
@carlocab
Copy link
Member

carlocab commented Oct 3, 2022

Thanks @jonchang!

@owine owine deleted the bump-netcdf-4.9.0 branch October 3, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` in progress Stale bot should stay away
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants