ceres-solver: remove gcc dependency on linux #106924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Jul 30, 2022
| depends_on "gcc" | ||
| end | ||
|
|
||
| fails_with gcc: "5" # C++17 |
There was a problem hiding this comment.
We should keep this line. The rest can be removed.
There was a problem hiding this comment.
I'm not a linux brew user, but I don't understand what that line would achieve on its own? (And it probably also fails with some other, later gcc versions.)
There was a problem hiding this comment.
I think it should help prevent brew from trying to use a host gcc-5 if that's all that's available, and we already know that that's hopeless.
carlocab
reviewed
Jul 30, 2022
| @@ -18,7 +18,6 @@ class CeresSolver < Formula | |||
| sha256 cellar: :any, monterey: "ab39d83b1ae0299e88f3fc9d5b23f19c98903d6452e21b6d363966ef5f4817d0" | |||
| sha256 cellar: :any, big_sur: "d1918fe281cb00dbb2d773c03252a0d50384688c32cb1ad92510f55c37276dca" | |||
| sha256 cellar: :any, catalina: "d6a945ae9d978b449228a795cfab9ab0061920f6c73f9cb93bb0a72946f4b206" | |||
| sha256 cellar: :any_skip_relocation, x86_64_linux: "5f095246dbff97818863a99864400c25278c6c23ee5bf42546eca75ae04f7de1" | |||
There was a problem hiding this comment.
Let's also add a comment above the bottle block about the removal of the Linux bottle.
|
Closing in favour of the mass-PR at #106926 |
chenrui333
added
not merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #100411