Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.9: bump setuptools & pip resources #107088

Closed
wants to merge 1 commit into from

Conversation

unitof
Copy link
Contributor

@unitof unitof commented Aug 2, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Bump outdated resources setuptools and pip

@BrewTestBot BrewTestBot added CI-linux-self-hosted Build on Linux self-hosted runner legacy Relates to a versioned @ formula labels Aug 2, 2022
@request-info
Copy link

request-info bot commented Aug 2, 2022

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Aug 2, 2022
@carlocab carlocab changed the title Bump setuptools resource python@3.9: bump setuptools resource Aug 2, 2022
@unitof
Copy link
Contributor Author

unitof commented Aug 2, 2022

Recommended by @carlocab #107080

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed needs response Needs a response from the issue/PR author labels Aug 2, 2022
@unitof unitof changed the title python@3.9: bump setuptools resource python@3.9: bump setuptools & pip resources Aug 2, 2022
@unitof unitof marked this pull request as ready for review August 2, 2022 01:47
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you squash all your commits together and use the commit message

python@3.9: update resources

?

@unitof unitof force-pushed the python-updatesetuptools branch from c0f2b9a to 2af683d Compare August 2, 2022 03:43
@cho-m cho-m added the long build Set a long timeout for formula testing label Aug 2, 2022
@unitof
Copy link
Contributor Author

unitof commented Aug 3, 2022

Could use some advice on what needs to be done.

All macOS Intels timed out.

On 11 and 12 arm64: chapel & protobuf@3 fail tests.

On linux, 21 formulae fail tests.

@carlocab
Copy link
Member

carlocab commented Aug 3, 2022

We need a long build slot to avoid the timeout. We'll just have to wait for one to free up.

Can you look at the chapel and protobuf@3 error log to see if it might be related to the changes here?

Most of the Linux failures might be fixed by a rebase.

@unitof
Copy link
Contributor Author

unitof commented Aug 4, 2022

Sounds good!

Does it automatically run when a long slot opens up, or is that something y'all monitor and rerun manually?

Will see what I can do about chapel and protobuf@3.

@carlocab
Copy link
Member

carlocab commented Aug 4, 2022

Right now this is monitored manually, but we're working on automating it.

@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 7, 2022
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@cho-m cho-m force-pushed the python-updatesetuptools branch from 2af683d to 908c451 Compare August 7, 2022 01:10
@cho-m cho-m removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-linux-self-hosted Build on Linux self-hosted runner labels Aug 7, 2022
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Aug 7, 2022
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@cho-m cho-m mentioned this pull request Aug 8, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. legacy Relates to a versioned @ formula long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants