Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchelf: revision for gcc #107388

Closed
wants to merge 1 commit into from
Closed

patchelf: revision for gcc #107388

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 5, 2022

Follow up of #106755

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka mentioned this pull request Aug 5, 2022
6 tasks
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; let's trigger a julia build on Linux when this is done.

@carlocab
Copy link
Member

carlocab commented Aug 5, 2022

It would also probably be good to know why my RPATH fix didn't work here.

@carlocab carlocab added automerge-skip `brew pr-automerge` will skip this pull request and removed automerge-skip `brew pr-automerge` will skip this pull request labels Aug 5, 2022
@carlocab
Copy link
Member

carlocab commented Aug 5, 2022

Ah, here's why the fix didn't work:

https://github.com/Homebrew/brew/blob/ff9c2500195cc357d4a06f99d462f8d8a5d37892/Library/Homebrew/extend/os/linux/keg_relocate.rb#L11-L12

We skip RPATH rewriting for patchelf. Not sure why we're doing that. I suspect it's because we used to use patchelf to do RPATH rewriting.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab
Copy link
Member

carlocab commented Aug 5, 2022

@BrewTestBot
Copy link
Member

@carlocab bottle request for julia failed.

@carlocab
Copy link
Member

carlocab commented Aug 5, 2022

Hmmm...

  ==> /home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/bin/julia --startup-file=no --history-file=no --project=/tmp/julia-test-20220805-63088-670cd2 --procs 2 --eval Base.runtests("core")
  Test  (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
  core       (1) |        started at 2022-08-05T16:47:48.152
  core       (1) |         failed at 2022-08-05T16:48:45.741
  Error During Test at /home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/share/julia/test/testdefs.jl:21
    Got exception outside of a @test
    LoadError: InexactError: Int64(1.526e-5)
    Stacktrace:
     [1] Int64
       @ ./float.jl:812 [inlined]
     [2] iterate
       @ ./generator.jl:47 [inlined]
     [3] collect_to!(dest::Vector{Int64}, itr::Base.Generator{Vector{Union{Nothing, Float16, Int8}}, Type{Int64}}, offs::Int64, st::Int64)
       @ Base ./array.jl:782
    in expression starting at /home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/share/julia/test/core.jl:5818
  
  
  Test Summary: |  Pass  Error  Broken  Total
    Overall     | 55684      1       1  55686
      core      | 55684      1       1  55686
      FAILURE
  
  The global RNG seed was 0x84c09634a21a56e6adf35bff8cc5d5b9.
  
  Error in testset core:
  Error During Test at /home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/share/julia/test/testdefs.jl:21
    Got exception outside of a @test
    LoadError: InexactError: Int64(1.526e-5)
    Stacktrace:
     [1] Int64
       @ ./float.jl:812 [inlined]
     [2] iterate
       @ ./generator.jl:47 [inlined]
     [3] collect_to!(dest::Vector{Int64}, itr::Base.Generator{Vector{Union{Nothing, Float16, Int8}}, Type{Int64}}, offs::Int64, st::Int64)
       @ Base ./array.jl:782
    in expression starting at /home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/share/julia/test/core.jl:5818
  ERROR: LoadError: Test run finished with errors
  in expression starting at /home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/share/julia/test/runtests.jl:94
  ERROR: A test has failed. Please submit a bug report (https://github.com/JuliaLang/julia/issues)
  including error messages above and the output of versioninfo():
  Julia Version 1.7.3
  Commit 742b9abb4d (2022-05-06 12:58 UTC)
  Platform Info:
    OS: Linux (x86_64-pc-linux-gnu)
    CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
    WORD_SIZE: 64
    LIBM: libopenlibm
    LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512)
  
  Stacktrace:
   [1] error(s::String)
     @ Base ./error.jl:33
   [2] runtests(tests::String; ncores::Int64, exit_on_error::Bool, revise::Bool, seed::Nothing)
     @ Base ./util.jl:635
   [3] runtests(tests::String)
     @ Base ./util.jl:617
   [4] top-level scope
     @ none:1
  
  caused by: failed process: Process(setenv(`/home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/bin/julia -Cnative -J/home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/lib/julia/sys.so -g1 --startup-file=no /home/linuxbrew/.linuxbrew/Cellar/julia/1.7.3_2/bin/../share/julia/test/runtests.jl core`,["CXX=/home/linuxbrew/.linuxbrew/bin/g++-12", "PATH=/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/cmd:/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/cmd:/usr/bin:/bin:/usr/sbin:/sbin", "HOMEBREW_USER_AGENT_CURL=Linuxbrew/3.5.8 (Linux; x86_64 5.15.0-1014-azure) curl/7.47.0", "HOMEBREW_BREW_DEFAULT_GIT_REMOTE=https://github.com/Homebrew/brew", "HOMEBREW_PRODUCT=Linuxbrew", "CC=/home/linuxbrew/.linuxbrew/bin/gcc-12", "MAKEFLAGS=-j2", "GIT_AUTHOR_NAME=BrewTestBot", "GIT_COMMITTER_EMAIL=1589480+BrewTestBot@users.noreply.github.com", "HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=1"  …  "HOMEBREW_REQUIRED_RUBY_VERSION=2.6.8", "CARGO_HOME=/home/linuxbrew/.cache/Homebrew/cargo_cache", "HOMEBREW_CURL_PATH=/usr/bin/curl", "CPPFLAGS=-isystem/home/linuxbrew/.linuxbrew/include", "LDFLAGS=-L/home/linuxbrew/.linuxbrew/lib", "HOMEBREW_ANALYTICS_USER_UUID=1cdbea89-a76a-4d71-979d-397054c4de5d", "HOMEBREW_BOOTSNAP=1", "HOMEBREW_GITHUB_PACKAGES_AUTH=***", "HOMEBREW_ANALYTICS_IDS=UA-76492262-1", "OPENBLAS_MAIN_FREE=1"]), ProcessExited(1)) [1]
  
  Stacktrace:
   [1] pipeline_error
     @ ./process.jl:540 [inlined]
   [2] run(::Cmd; wait::Bool)
     @ Base ./process.jl:455
   [3] run
     @ ./process.jl:453 [inlined]
   [4] runtests(tests::String; ncores::Int64, exit_on_error::Bool, revise::Bool, seed::Nothing)
     @ Base ./util.jl:629
   [5] runtests(tests::String)
     @ Base ./util.jl:617
   [6] top-level scope
     @ none:1
  Error: julia: failed

https://github.com/Homebrew/homebrew-core/runs/7695138907?check_suite_focus=true#step:8:131

@iMichka iMichka deleted the patchelf branch August 5, 2022 20:50
@carlocab carlocab mentioned this pull request Aug 12, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants