speedtest-cli: fix test #110021
Merged
speedtest-cli: fix test #110021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
the
python
Closed
iMichka
force-pushed
the
speedtest-cli
branch
from
cedaf2e
to
7bc4316
Compare
chenrui333
added
linux
iMichka
force-pushed
the
speedtest-cli
branch
from
7bc4316
to
12a1df7
Compare
Test fails with: ERROR: Unable to connect to servers to test latency. I can reproduce this locally too, maybe upstreams servers are down / something has changed. Note that I am on tethered connection on a phone right now, so this might explain the issue on my side. Testing the version and help commands is probably enough here as we just make sure the python code can be executed (there is only a single python file in this project), and avoids any fragile connection to speedtest's servers
iMichka
force-pushed
the
speedtest-cli
branch
from
12a1df7
to
27c2863
Compare
carlocab
approved these changes
Sep 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fails with: ERROR: Unable to connect to servers to test latency.
I can reproduce this locally too, maybe upstreams servers are down / something has changed.
Note that I am on tethered connection on a phone right now, so this might explain the issue on my side.
Testing the version and help commands is probably enough here as we just make sure the python code
can be executed (there is only a single python file in this project), and avoids any fragile
connection to speedtest's servers
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?