Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: disable keyring in tests #110394

Closed
wants to merge 1 commit into from
Closed

poetry: disable keyring in tests #110394

wants to merge 1 commit into from

Conversation

xxyzz
Copy link
Contributor

@xxyzz xxyzz commented Sep 12, 2022

The tests would fail in CI when keyring is enabled

The Failed to unlock the item! error message in this pr #109777 (comment) is from https://github.com/jaraco/keyring/blob/977ed03677bb0602b91f005461ef3dddf01a49f6/keyring/backends/SecretService.py#L70-L74 or https://github.com/jaraco/keyring/blob/977ed03677bb0602b91f005461ef3dddf01a49f6/keyring/backends/libsecret.py#L59-L78

The tests probably don't need keyring, so disable it should be fine.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The tests would fail in CI when keyring is enabled
@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Sep 12, 2022
@carlocab carlocab changed the title Disable keyring in poetry tests poetry: disable keyring in tests Sep 12, 2022
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Sep 12, 2022
@xxyzz
Copy link
Contributor Author

xxyzz commented Sep 12, 2022

Why it's building the build system(["hatchling", "hatch-vcs", "hatch-fancy-pypi-readme"]) of the "jsonschema" package?

@SMillerDev
Copy link
Member

Because it's a dependency

@iMichka
Copy link
Member

iMichka commented Sep 12, 2022

I'm trying something else, bumping the resources: #110433

@xxyzz
Copy link
Contributor Author

xxyzz commented Sep 12, 2022

I'm trying something else, bumping the resources

I guess the builds success in your pull request is because brew test-bot runs different build commands. Maybe updating dependencies will fix the test error.

@iMichka
Copy link
Member

iMichka commented Sep 12, 2022

#110433 Fixed it :)

@iMichka iMichka closed this Sep 12, 2022
@xxyzz xxyzz deleted the potery branch September 12, 2022 22:57
@xxyzz xxyzz restored the potery branch September 25, 2022 05:37
@xxyzz
Copy link
Contributor Author

xxyzz commented Sep 25, 2022

Not sure if you still want to merge this to solve the Python CI error but I guess if I create a new pull request it'll fail to build again.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants