Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm 4.0.0 #11044

Closed
wants to merge 9 commits into from
Closed

llvm 4.0.0 #11044

wants to merge 9 commits into from

Conversation

ilovezfs
Copy link
Contributor

Created with brew bump-formula-pr.

@ts826848
Copy link
Contributor

Can't wait to see how many formulae this will break!

Also, is lld officially the default linker for clang now? If so, how badly might that mess with homebrew?

@AraHaan
Copy link

AraHaan commented Mar 13, 2017

love how this somehow fails.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 14, 2017 •
edited
Loading

@AraHaan that's expected with creduce. I haven't even done the revision bumps yet, which is when it will really start to break.

@fxcoudert
Copy link
Member

@ilovezfs
Copy link
Contributor Author

@fxcoudert yeah. already dealt with locally ;)

@ilovezfs ilovezfs requested a review from MikeMcQuaid March 14, 2017 12:42
ilovezfs
ilovezfs commented Mar 14, 2017
View reviewed changes
Copy link
Contributor Author

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

==> FAILED
Error: 1 problem in 1 formula
llvm@3.9:
  * `head block` (line 78) should be put before `keg_only` (line 76)

ilovezfs
ilovezfs commented Mar 14, 2017
View reviewed changes
Copy link
Contributor Author

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the llvm@3.9 formula since ponyc can use the preexisting llvm@3.8 formula.

@ilovezfs ilovezfs mentioned this pull request Mar 14, 2017
Closed
@ilovezfs ilovezfs closed this in 26f2fab Mar 14, 2017
@ilovezfs
Copy link
Contributor Author

Shipped without the nvc bump, which I'll do in a separate PR.

@ilovezfs
Copy link
Contributor Author

nvc #11088

@AraHaan
Copy link

AraHaan commented Mar 14, 2017 •
edited
Loading

but what about having homebrew install 4.0.0?

oh nvm I just noticed your commit.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AraHaan AraHaan AraHaan approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ilovezfs @ts826848 @AraHaan @fxcoudert @MikeMcQuaid