Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse formulas : depend on Linux (2/2) #116188

Merged
merged 16 commits into from
Nov 20, 2022
Merged

Fuse formulas : depend on Linux (2/2) #116188

merged 16 commits into from
Nov 20, 2022

Conversation

fxcoudert
Copy link
Member

Part 1 was there: #116090

  • They have been disabled on macOS for 18 months, and are untested
  • Most of them don't have bottles anymore
  • Those that have bottles are for macOS versions we don't support anymore

At this stage it makes sense to make them juste Linux-only. It reflects the reality 😄

@BrewTestBot BrewTestBot added the linux-only Formula depends on Linux label Nov 19, 2022
@fxcoudert fxcoudert added the CI-no-bottles Merge without publishing bottles label Nov 19, 2022
@fxcoudert
Copy link
Member Author

==> go build -o goofys -ldflags -X main.Version=45b8d78375af1b24604439d2e60c567654bcdf88
  # github.com/kahing/goofys
  github.com/kahing/goofys/vendor/github.com/jacobsa/fuse/internal/buffer.memclr: relocation target runtime.memclrNoHeapPointers not defined for ABI0 (but is defined for ABIInternal)

@cho-m
Copy link
Member

cho-m commented Nov 19, 2022

==> go build -o goofys -ldflags -X main.Version=45b8d78375af1b24604439d2e60c567654bcdf88
  # github.com/kahing/goofys
  github.com/kahing/goofys/vendor/github.com/jacobsa/fuse/internal/buffer.memclr: relocation target runtime.memclrNoHeapPointers not defined for ABI0 (but is defined for ABIInternal)

Probably fixed in kahing/goofys#689. May have been broken when updating go versions (current Linux bottle is from August 2021 and was using go 1.16)

@cho-m
Copy link
Member

cho-m commented Nov 19, 2022

On side note, has anyone tested what happens when a macOS user has installed one of these formulae and then the formula gets switched to Linux-only?

I think there was a discussion for at-spi2-atk where Homebrew had removed the formula and then re-added it as Linux-only. Haven't personally checked how Homebrew commands behave (e.g. update, upgrade, outdated, doctor).

@fxcoudert
Copy link
Member Author

We've disabled them for 18 months, and redirected people to the external tap. This tap is well used, for example for ntfs-3g there are 1,588 monthly installs through the tap, compared to 45 through homebrew-core. We're not leaving people without an option.

Re. goofys, it can be fixed independently of this PR… it has very low install count anyway (3 monthly installs).

Given the first part was approved and merged, I intend to merge this today.

@fxcoudert fxcoudert requested a review from SMillerDev November 20, 2022 13:02
@fxcoudert fxcoudert merged commit fd37bb4 into Homebrew:master Nov 20, 2022
@fxcoudert fxcoudert deleted the fuse2 branch November 20, 2022 13:59
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles linux-only Formula depends on Linux outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants