Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl@1.1: make keg_only on Linux #119967

Closed
wants to merge 2 commits into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jan 7, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Experimenting on what is broken. Probably won't work yet.

Progress on migration on non-deprecated formulae (2022-01-06):

 306 openssl@1.1
 186 openssl@3

Mainly want to align the alias and symlink. Currently openssl@3 is aliased (openssl) but openssl@1.1 is symlinked.

This makes it less ideal compared to how we handle this for python where we can just do something like uses_from_macos <alias> and know that corresponding one will have executables available on PATH.

Right now, we need to do depends_on "openssl@1.1" or manually manipulate PATH to guarantee that the command openssl will be available.

@cho-m cho-m added do not merge in progress Stale bot should stay away CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 7, 2023
@BrewTestBot BrewTestBot added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Jan 7, 2023
@cho-m cho-m added long build Set a long timeout for formula testing and removed long build Set a long timeout for formula testing labels Jan 7, 2023
@dawidd6
Copy link
Member

dawidd6 commented Jan 10, 2023

Progress on migration on non-deprecated formulae (2022-01-06):

I guess you mistyped the year 😄

@cho-m cho-m mentioned this pull request Feb 12, 2023
@carlocab
Copy link
Member

Merged to openssl-migration-staging in #134234.

@carlocab carlocab closed this Jun 20, 2023
@cho-m cho-m deleted the openssl-keg-switch branch October 30, 2023 22:38
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. in progress Stale bot should stay away outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants