Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer: generate script for base and ges tools #120206

Closed
wants to merge 1 commit into from

Conversation

dabrain34
Copy link

@dabrain34 dabrain34 commented Jan 10, 2023

Generate script for the tools where the GST_PLUGIN_SYSTEM_PATH is defined properly

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@sdroege
Copy link

sdroege commented Jan 10, 2023

Don't create more hacks for working around packaging mistakes in the GStreamer recipes. See https://github.com/orgs/Homebrew/discussions/3740 for the proper solution.

@dabrain34
Copy link
Author

I gave a try to a fresh Linux toolbox to check what was occuring and it seems to work fine without GST_PLUGIN_SYSTEM_PATH.

So I guess the patch would be more to remove the line than adding in gst-plugins-base
bin.env_script_all_files libexec/"bin", GST_PLUGIN_SYSTEM_PATH: HOMEBREW_PREFIX/"lib/gstreamer-1.0" in gstreamer recipe.

GST_PLUGIN_SYSTEM_PATH is set internally
by the recipe. No need for the wrapper script
@timvahlbrock
Copy link

@chenrui333
Copy link
Member

Can someone volunteer to merge the gstreamer formulae?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 6, 2023
@github-actions github-actions bot closed this Feb 14, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
@carlocab
Copy link
Member

Note: This should no longer be an issue with the latest build of GStreamer. Feel free to file an issue if it's still causing you problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants