Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmu-sphinxbase: deprecate #123443

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

samford
Copy link
Member

@samford samford commented Feb 16, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

PocketSphinx 5.0.0 no longer uses SphinxBase as a separate dependency, so we can seemingly deprecate the cmu-sphinxbase formula after #123396 is merged (I'll rebase this and mark it as "ready for review" afterward).

@samford samford added formula deprecated Formula deprecated CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 16, 2023
@cho-m cho-m mentioned this pull request Feb 16, 2023
22 tasks
@p-linnane p-linnane force-pushed the cmu-sphinxbase-deprecate branch from f9b72e2 to a42d982 Compare February 17, 2023 02:02
@p-linnane p-linnane marked this pull request as ready for review February 17, 2023 02:02
@p-linnane p-linnane merged commit 7c49c4f into Homebrew:master Feb 17, 2023
@samford samford deleted the cmu-sphinxbase-deprecate branch February 17, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants