Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@14: deprecate on 2023-04-30 (EOL) #123650

Closed
wants to merge 4 commits into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 19, 2023

Planning for upcoming node@14 EOL.

Checking for maintainer feedback on how we want to handle this, e.g.


As note, both balena-cli and opensearch-dashboards were stuck on EOL NodeJS (node@12 and node@10 respectively) for a while.

@cho-m cho-m added do not merge maintainer feedback Additional maintainers' opinions may be needed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 19, 2023
@BrewTestBot BrewTestBot added the formula deprecated Formula deprecated label Feb 19, 2023
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for option 1

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for option 1, in line with upstream decision.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say option 1 (deprecate on 2023-04-30) with a full disable date of 2023-09-11.

@Bo98
Copy link
Member

Bo98 commented Feb 19, 2023

We'll need to discuss strategy regarding OpenSSL 1.1 soon (because of notice periods). We're usually quite strict with security formulae - we outright deleted OpenSSL 1.0 on its EOL date last time so we'll need to discuss when exactly when we deprecate and when we disable (3 months minimum between the two stages).

This in turn affects Node 16.

@chenrui333
Copy link
Member

for option1 (life is easier 😅 )

@cho-m
Copy link
Member Author

cho-m commented Feb 20, 2023

Removing do not merge based on feedback. May add a comment to upstream issues to notify of upcoming deprecation.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the node14-future-deprecation branch February 21, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated maintainer feedback Additional maintainers' opinions may be needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants