Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastfec 0.1.9 #123946

Closed
wants to merge 3 commits into from
Closed

fastfec 0.1.9 #123946

wants to merge 3 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Feb 22, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Requires a patch for bottling. Works for me locally; will upstream if it works in CI.

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 22, 2023
@carlocab
Copy link
Member Author

Linux is failing because of ziglang/zig#14111.

@carlocab carlocab added ready to merge PR can be merged once CI is green and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Feb 22, 2023
# Use Homebrew PCRE on Linux when upstream resolves
# https://github.com/ziglang/zig/issues/14111
# Don't forget to update the `install` method.
depends_on "pcre"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it use pcre2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there isn't an issue yet, could you make one for that too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@carlocab carlocab deleted the fastfec branch February 22, 2023 13:19
@carlocab carlocab mentioned this pull request Feb 27, 2023
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
@chenrui333 chenrui333 added the zig Zig use is a significant feature of the PR or issue label Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green zig Zig use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants