gstreamer: use monorepo build #125996

carlocab · 2023-03-17T23:00:58Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Upstream have merged all their projects into a monorepo. [1] The
supported way of building the various projects is through the monorepo,
so we should do that.

See Homebrew/discussions#3740 for additional context.

Resolves Homebrew/discussions#3740.

[1] https://gstreamer.freedesktop.org/documentation/frequently-asked-questions/mono-repository.html?gi-language=c

carlocab · 2023-03-18T08:06:22Z

OSError: [Errno 86] Bad CPU type in executable: '/private/tmp/gstreamer-20230318-31006-a2njdq/gstreamer-1.22.1/subprojects/macos-bison-binary/bison-3.7.6-macos-x86_64/bin/bison'

Why are you downloading your own bison? How annoying.

carlocab · 2023-03-18T11:02:36Z

  error[E0069]: `return;` in a function whose return type is not `()`
     --> video/gtk4/src/sink/imp.rs:856:21
      |
  856 |                     return;
      |                     ^^^^^^ return type is not `()`
  
  For more information about this error, try `rustc --explain E0069`.

~~Not sure why this didn't fail when building gst-plugins-rs previously, though.~~ Different tag.

Formula/gstreamer.rb

carlocab

Ah, wait. This will need a whole lot of link_overwrites, probably.

Formula/gstreamer.rb

Formula/aravis.rb

Formula/gstreamer.rb

github-actions · 2023-04-14T03:16:32Z

@carlocab has requested bottles to be published to this PR.

nirbheek

This is great stuff!

nirbheek · 2023-04-14T07:28:07Z

Formula/gstreamer.rb

-      system "ninja", "install", "-v"
-    end
+    # The apple media plug-in uses API that was added in Mojave
+    args << "-Dgst-plugins-bad:applemedia=disabled" if MacOS.version <= :high_sierra


This is not correct, the applemedia plugin supports 10.11 (El Capitan) and newer. That is how the official gstreamer binaries are built. What problems were you having?

This line originates from 03d561a, with associated PR at #52730. We don't test on systems older than Big Sur anymore, so I guess this has been fixed since then.

nirbheek · 2023-04-14T07:29:51Z

Formula/gstreamer.rb

+    args = %W[
+      -Dpython=enabled
+      -Dlibav=enabled
+      -Dlibnice=disabled


libnice is actually a really important gstreamer plugin, since it's essential for webrtc support.

I am not sure how you can solve the circular dep though. Maybe you could move libnice into the monorepo too? Is there anything else in Homebrew that uses libnice?

Maybe you could move libnice into the monorepo too?

Yea, maybe. It'll make updating libnice really annoying, though. It's also not clear to me that you get the same libnice if you build it before Gstreamer rather than after, which might be an issue for users.

Is there anything else in Homebrew that uses libnice?

Not currently, no.

The monorepo will pull in libnice in the same way that it pulls in gst-plugins-rs (both are separate repos that are meson wraps), so it will be identical to building it separately. If nothing else is using libnice, then I suggest merging it into the monorepo too.

Note that libnice is maintained by Olivier, who is a gstreamer core maintainer, and I don't expect anyone outside of gstreamer to use the project.

If you really want to keep it separate, I'd recommend building it twice: once as its own project without gstreamer support, then again as part of the monorepo to build only the gstreamer plugin. That'll require non-trivial build system patching, but it can be done.

It's not quite the same as gst-plugins-rs, though, which kind of supports updating simultaneously with gstreamer.

If we build libnice with gstreamer, then we need to rebuild all of gstreamer every time we want to update only libnice (if we even remember to update it after it becomes part of gstreamer).

The libnice wrap file is continuously updated, so you'd get updates whenever you update gstreamer (stable releases for instance). We test the two as a unit in the monorepo and in cerbero.

Hi! Thanks for documenting the issue: upgrading to 1.22.2 effectively made webrtcbin no longer be listed as plugin. I understand the circular dependency issue, can some work be done to include libnice so that webrtcbin is supported? It's not clear what the best approach is if libnice still needs to be a standalone.

Did webrtc work for you before? @nirbheek tells me that it was basically broken previously.

Did webrtc work for you before?

Up until 1.20.0 at least what it took was for gstreamer + gst-plugins-bad to be installed via brew in which case it was working yes.

Earlier, all plugin registration was broken unless you set the right env vars, and linking was also broken. webrtcbin was not specifically broken.

I can help you with a solution for the circular dep, just let me know if you need my help.

One way would be to allow gstnice (inside libnice) to be built against a system libnice. The plugin only uses the version string at build time, nothing else.

I can patch that and talk to Olivier about upstreaming it.

One way would be to allow gstnice (inside libnice) to be built against a system libnice. The plugin only uses the version string at build time, nothing else.

That seems like it could work.

If you could point at the right places to patch I'll have a look at applying it to the formula.

nirbheek · 2023-04-14T07:33:48Z

Formula/gstreamer.rb


-    bin.env_script_all_files libexec/"bin", GST_PLUGIN_SYSTEM_PATH: HOMEBREW_PREFIX/"lib/gstreamer-1.0"
+    # Prevent the build from downloading an x86-64 version of bison.
+    inreplace "meson.build", "subproject('macos-bison-binary')", ""


Ah, hmm, we should provide a way to disable this. I'll fix it upstream :)

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4428

You can start using this with the 1.24 release.

spiegela · 2023-04-14T18:48:07Z

Interesting, when installing this version, gstreamer pulls in both gtk+3 and gtk+4 for me, but then gst-inspect-1.0 complains about them both being installed:

objc[52356]: Class ResultReceiver is implemented in both /opt/homebrew/Cellar/gtk+3/3.24.37/lib/libgtk-3.0.dylib (0x106cd5df8) and /opt/homebrew/Cellar/gtk4/4.10.1/lib/libgtk-4.1.dylib (0x1159c2ec0). One of the two will be used. Which one is undefined.

edit

nevermind... uninstalling gtk+3 and gtk+4, then re-installing gstreamer seems to have resolved the errors

Similar to orc, allow distros to force bison, flex, nasm, etc, to be provided by the system. Needed by the Homebrew folks: Homebrew/homebrew-core#125996 (comment) Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4428>

BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 17, 2023

This comment was marked as resolved.

Sign in to view

carlocab force-pushed the gstreamer branch 3 times, most recently from 8dff2cb to e85e2e3 Compare March 18, 2023 07:18

carlocab force-pushed the gstreamer branch from e85e2e3 to 848dd1c Compare March 18, 2023 08:14

carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Mar 18, 2023

carlocab force-pushed the gstreamer branch from 848dd1c to ae5c709 Compare March 18, 2023 10:26

carlocab added the CI-linux-self-hosted Build on Linux self-hosted runner label Mar 18, 2023

carlocab commented Mar 18, 2023

View reviewed changes

Formula/gstreamer.rb Outdated Show resolved Hide resolved

carlocab force-pushed the gstreamer branch 6 times, most recently from 64109ff to e77c4da Compare March 18, 2023 20:07

carlocab marked this pull request as ready for review March 18, 2023 20:08

carlocab commented Mar 18, 2023

View reviewed changes

carlocab added the long build Set a long timeout for formula testing label Mar 19, 2023

SMillerDev added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 19, 2023

carlocab commented Mar 19, 2023

View reviewed changes

Formula/gstreamer.rb Outdated Show resolved Hide resolved

carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 19, 2023

carlocab force-pushed the gstreamer branch 2 times, most recently from 541a848 to 084174a Compare March 20, 2023 02:33

carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 20, 2023

carlocab force-pushed the gstreamer branch from 084174a to d4a9062 Compare March 20, 2023 04:30

carlocab commented Mar 20, 2023

View reviewed changes

Formula/aravis.rb Outdated Show resolved Hide resolved

carlocab commented Mar 20, 2023

View reviewed changes

Formula/gstreamer.rb Show resolved Hide resolved

carlocab added 2 commits April 13, 2023 21:40

virt-manager: revision bump (gstreamer monorepo rebuild)

7aa9e4b

webkitgtk: revision bump (gstreamer monorepo rebuild)

c89dfd7

carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 13, 2023

carlocab force-pushed the gstreamer branch from b9b3712 to c89dfd7 Compare April 13, 2023 13:41

carlocab added ready to merge PR can be merged once CI is green and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Apr 13, 2023

carlocab requested a review from a team April 14, 2023 01:40

p-linnane approved these changes Apr 14, 2023

View reviewed changes

BrewTestBot added 9 commits April 14, 2023 03:18

efl: update 1.26.3_3 bottle.

d50fa10

spice-gtk: update 0.42_1 bottle.

4566b65

webkitgtk: update 2.40.0_1 bottle.

8f3f248

pympress: update 1.8.2_1 bottle.

7cbff38

aravis: update 0.8.26_1 bottle.

bcf4bc8

gstreamer: update 1.22.1_1 bottle.

b396944

virt-manager: update 4.1.0_4 bottle.

cb7620b

libusrsctp: update 0.9.5.0_1 bottle.

b2c5a79

pdfpc: update 4.4.1_2 bottle.

5e81cb1

github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 14, 2023

carlocab added this pull request to the merge queue Apr 14, 2023

Merged via the queue into Homebrew:master with commit bc184bb Apr 14, 2023

carlocab deleted the gstreamer branch April 14, 2023 03:42

nirbheek reviewed Apr 14, 2023

View reviewed changes

fduncanh mentioned this pull request Apr 16, 2023

Question: Why is the video very blurry? FDH2/UxPlay#190

Closed

mukilan mentioned this pull request Apr 21, 2023

MacOS builds are broken due to missing Gstreamer plugins. servo/servo#29653

Closed

github-actions bot added the outdated PR was locked due to age label May 30, 2023

github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gstreamer: use monorepo build #125996

gstreamer: use monorepo build #125996

carlocab commented Mar 17, 2023 •

edited

Loading

This comment was marked as resolved.

carlocab commented Mar 18, 2023

carlocab commented Mar 18, 2023 •

edited

Loading

carlocab left a comment

github-actions bot commented Apr 14, 2023

nirbheek left a comment

nirbheek Apr 14, 2023

carlocab Apr 14, 2023

nirbheek Apr 14, 2023

carlocab Apr 14, 2023

nirbheek Apr 14, 2023

carlocab Apr 14, 2023

nirbheek Apr 14, 2023

cooltea713705 Apr 27, 2023 •

edited

Loading

carlocab Apr 27, 2023

cooltea713705 Apr 27, 2023 •

edited

Loading

nirbheek Apr 28, 2023

carlocab Apr 28, 2023 •

edited

Loading

nirbheek Apr 14, 2023

nirbheek Apr 14, 2023

carlocab Apr 14, 2023

spiegela commented Apr 14, 2023 •

edited

Loading

gstreamer: use monorepo build #125996

gstreamer: use monorepo build #125996

Conversation

carlocab commented Mar 17, 2023 • edited Loading

This comment was marked as resolved.

carlocab commented Mar 18, 2023

carlocab commented Mar 18, 2023 • edited Loading

carlocab left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 14, 2023

nirbheek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cooltea713705 Apr 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cooltea713705 Apr 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlocab Apr 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spiegela commented Apr 14, 2023 • edited Loading

carlocab commented Mar 17, 2023 •

edited

Loading

carlocab commented Mar 18, 2023 •

edited

Loading

cooltea713705 Apr 27, 2023 •

edited

Loading

cooltea713705 Apr 27, 2023 •

edited

Loading

carlocab Apr 28, 2023 •

edited

Loading

spiegela commented Apr 14, 2023 •

edited

Loading