Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opal 1.7.3 (new formula) #126482

Merged
merged 2 commits into from
Mar 25, 2023
Merged

opal 1.7.3 (new formula) #126482

merged 2 commits into from
Mar 25, 2023

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Mar 23, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core ruby Ruby use is a significant feature of the PR or issue labels Mar 23, 2023
carlocab
carlocab reviewed Mar 23, 2023
View reviewed changes
Formula/opal.rb Outdated Show resolved Hide resolved
Formula/opal.rb
class Opal < Formula
desc "Ruby to JavaScript transpiler"
homepage "https://opalrb.com/"
url "https://github.com/opal/opal.git",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the Git clone?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there's submodules. I initially tried with tarball and it just ended up building nothing.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Mar 25, 2023
@github-actions
Copy link
Contributor

:shipit: @ZhongRuoyu has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 25, 2023
@ZhongRuoyu ZhongRuoyu merged commit 9accade into Homebrew:master Mar 25, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alebcay @chenrui333 @carlocab @BrewTestBot @ZhongRuoyu