vorbis-tools: Fix build on Ventura #130403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
added
the
CI-no-fail-fast
carlocab
reviewed
May 8, 2023
carlocab
added
CI-no-bottles
|
Let's try a different fix... |
github-actions
bot
added
the
autosquash
carlocab
force-pushed
the
vorbis
branch
2 times, most recently
from
fc97ef1 to
dde49a6
Compare
|
Trying again, I added libtool to the build to make it pass. |
|
Cool, thanks. Will upstream the patch then we can get this merged. Might not get to it till later though. |
github-actions
bot
removed
the
autosquash
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@carlocab still want to upstream the patch? Looking at xiph/vorbis-tools#27 it's unlikely this will get a new release anyway. |
|
...ah. Guess not then. |
carlocab
approved these changes
Jun 1, 2023
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?