Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icoutils: Fix build on Ventura #130568

Merged
merged 2 commits into from
May 16, 2023
Merged

icoutils: Fix build on Ventura #130568

merged 2 commits into from
May 16, 2023

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented May 9, 2023

Fixes:
2023-04-18T16:36:52.8543510Z ld: in ../common/libcommon.a(libgnu.a), archive member 'libgnu.a' with length 48528 is not mach-o or llvm bitcode file '../common/libcommon.a' for architecture x86_64

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka requested a review from carlocab May 9, 2023 20:12
@github-actions github-actions bot added the deprecated license Formula uses a deprecated SPDX license which should be updated label May 9, 2023
@iMichka iMichka requested a review from fxcoudert May 9, 2023 20:12
Fixes:
2023-04-18T16:36:52.8543510Z ld: in ../common/libcommon.a(libgnu.a), archive member 'libgnu.a' with length 48528 is not mach-o or llvm bitcode file '../common/libcommon.a' for architecture x86_64
@iMichka iMichka marked this pull request as ready for review May 15, 2023 21:13
@iMichka
Copy link
Member Author

iMichka commented May 15, 2023

I have sent an email to upstream with an explanation and asked for a fix. Let's ship this, no need to wait for answer now.

@iMichka iMichka requested review from carlocab and fxcoudert May 16, 2023 20:34
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 16, 2023
@BrewTestBot BrewTestBot enabled auto-merge May 16, 2023 21:49
@BrewTestBot BrewTestBot added this pull request to the merge queue May 16, 2023
Merged via the queue into Homebrew:master with commit a73f26d May 16, 2023
@iMichka iMichka deleted the icoutils branch May 19, 2023 21:28
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. deprecated license Formula uses a deprecated SPDX license which should be updated outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants