Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a2ps: opt-imize cfg paths #132061

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented May 26, 2023

Fixes https://github.com/orgs/Homebrew/discussions/4531.

No revision bump, because upgrades won't fix existing config files anyway.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -29,6 +29,7 @@ def install
"--with-packager-version=#{pkg_version}",
"--with-packager-bug-reports=#{tap.issues_url}"
system "make", "install"
inreplace etc/"a2ps.cfg", prefix, opt_prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really have an audit for this at this point.

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 26, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue May 26, 2023
Merged via the queue into Homebrew:master with commit 3ba1fbb May 26, 2023
@gromgit gromgit deleted the a2ps/fix-cfg-paths branch June 2, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants