Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-cpp 1.9.1 #132204

Closed
wants to merge 3 commits into from
Closed

opentelemetry-cpp 1.9.1 #132204

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69faca3
opentelemetry-cpp 1.9.1
chenrui333 May 28, 2023
2c25817
opentelemetry-cpp: build with dynamic_lookup
cho-m Jul 1, 2023
e69d6e9
opentelemetry-cpp: fix test on Linux
cho-m Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Formula/opentelemetry-cpp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ class OpentelemetryCpp < Formula
desc "OpenTelemetry C++ Client"
homepage "https://opentelemetry.io/"
# TODO: Check if we can use unversioned `grpc` and `protobuf` at version bump.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work with new protobuf/grpc.

url "https://github.com/open-telemetry/opentelemetry-cpp/archive/refs/tags/v1.8.2.tar.gz"
sha256 "20fa97e507d067e9e2ab0c1accfc334f5a4b10d01312e55455dc3733748585f4"
url "https://github.com/open-telemetry/opentelemetry-cpp/archive/refs/tags/v1.9.1.tar.gz"
sha256 "668de24f81c8d36d75092ad9dcb02a97cd41473adbe72485ece05e336db48249"
license "Apache-2.0"
revision 1
head "https://github.com/open-telemetry/opentelemetry-cpp.git", branch: "main"

bottle do
Expand All @@ -28,6 +27,7 @@ class OpentelemetryCpp < Formula
uses_from_macos "curl"

def install
ENV.append "LDFLAGS", "-Wl,-undefined,dynamic_lookup" if OS.mac?
system "cmake", "-S", ".", "-B", "build",
"-DCMAKE_CXX_STANDARD=17", # Keep in sync with C++ standard in abseil.rb
"-DCMAKE_INSTALL_RPATH=#{rpath}",
Expand Down Expand Up @@ -79,8 +79,8 @@ def install
"-I#{include}", "-L#{lib}",
"-I#{Formula["protobuf@21"].opt_include}",
"-lopentelemetry_resources",
"-lopentelemetry_trace",
"-lopentelemetry_exporter_ostream_span",
"-lopentelemetry_trace",
"-lopentelemetry_common",
"-pthread",
"-o", "simple-example"
Expand Down