-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby@2.7: switch to openssl@3
#134420
ruby@2.7: switch to openssl@3
#134420
Conversation
I think OpenSSL 3 support was never backported to Ruby 3.0 and earlier, so worth watching out for that (Ruby build is notorious for just skipping modules if it fails). Ruby 2.7 could be disabled by the time OpenSSL 1.1 is EOL should we choose. Though we'll need to do something for Ruby 3.0 anyway. An option is backporting the OpenSSL gem (3.0.2?). Upstream thought about doing this themselves (https://bugs.ruby-lang.org/issues/18658) but declined to do so since they wanted to retain OpenSSL 1.0.x compatibility. There are some other compatibility concerns however: https://github.com/ruby/openssl/blob/master/History.md#compatibility-notes LibreSSL is an option but one I'm unsure of the consequences of, and is something we've generally not used (except movgrab apparently). |
Yea, looks like it just refuses to build: |
d41649b
to
2451506
Compare
Then can we replace |
I reckon we either offer a similar fix as we did to ruby@3.0. If that doesn't work, Ruby 2.7 is already EOL anyway. |
2451506
to
70ab3a6
Compare
Let's see if an older openssl gem works. |
9cfcab1
to
a3fb695
Compare
We need to update the openssl gem to do this.
a3fb695
to
fb4bb76
Compare
Dependent failure is spurious: https://github.com/Homebrew/homebrew-core/actions/runs/5380336644/jobs/9763600018?pr=134420#step:4:35 In any case, the only dependent is deprecated. |
This is because of its use in |
🤖 An automated task has requested bottles to be published to this PR. |
Hi, I didn't understand why ruby 2.7 was bumped to openssl@3? As mentioned in the comments and the ruby bug tracker that combination is not supported. |
See #134251.