Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wandio 4.2.5 libtrace 4.0.22 #134422

Merged

Conversation

carlocab
Copy link
Member

See #134251.

@carlocab carlocab added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 21, 2023
@carlocab
Copy link
Member Author

Looks like they moved to GitHub: https://github.com/LibtraceTeam/libtrace.git

@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software labels Jun 21, 2023
@p-linnane p-linnane force-pushed the libtrace-openssl3 branch from f73ae5d to 4eb26ee Compare June 21, 2023 19:58
@nandahkrishna nandahkrishna changed the title libtrace: switch to openssl@3 wandio 4.2.5 libtrace 4.0.22 Jun 23, 2023
@nandahkrishna nandahkrishna added livecheck Issues or PRs related to livecheck and removed help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software labels Jun 23, 2023
@carlocab
Copy link
Member Author

Thanks @nandahkrishna!

@nandahkrishna
Copy link
Member

Updated wandio to 4.2.5 and libtrace to 4.0.22 along with the openssl@3 switch.

Note on livecheck and version

Both formulae seem to have tags with a -1 suffix, but upstream seems to ignore this from the version (see: wandio releases page and Repology, libtrace releases page and Repology).

I've updated the livecheck blocks such that the -1 suffix is ignored (but -2 and higher are not). I've also added a version in line with this change.

CC @samford for feedback, but we can also revisit this later.

@nandahkrishna
Copy link
Member

nandahkrishna commented Jun 23, 2023

Hm, no openssl@3 linkage on Linux:

==> brew linkage --cached libtrace
System libraries:
  /lib/x86_64-linux-gnu/libc.so.6
  /lib/x86_64-linux-gnu/libgcc_s.so.1
  /lib/x86_64-linux-gnu/libm.so.6
  /lib/x86_64-linux-gnu/libstdc++.so.6
Homebrew libraries:
  /home/linuxbrew/.linuxbrew/opt/libpcap/lib/libpcap.so.1 (libpcap)
  /home/linuxbrew/.linuxbrew/Cellar/libtrace/4.0.22/lib/libpacketdump.so.5 (libtrace)
  /home/linuxbrew/.linuxbrew/Cellar/libtrace/4.0.22/lib/libtrace.so.7 (libtrace)
  /home/linuxbrew/.linuxbrew/opt/ncurses/lib/libncursesw.so.6 (ncurses)
  /home/linuxbrew/.linuxbrew/opt/wandio/lib/libwandio.so.6 (wandio)
Indirect dependencies with linkage:
  ncurses

All macOS versions seem to have linkage though.

@carlocab
Copy link
Member Author

Seems fine to merge. Will pull in OpenSSL via uses_from_macos "curl" in wandio anyway.

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Jun 23, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 23, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 23, 2023 15:07
@BrewTestBot BrewTestBot merged commit 912ba07 into Homebrew:openssl-migration-staging Jun 23, 2023
@carlocab carlocab deleted the libtrace-openssl3 branch June 23, 2023 16:11
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. livecheck Issues or PRs related to livecheck openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants