Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache-arrow, gdal, pdal: switch to openssl@3 #134428

Merged
merged 6 commits into from
Jun 26, 2023
Merged

apache-arrow, gdal, pdal: switch to openssl@3 #134428

merged 6 commits into from
Jun 26, 2023

Conversation

carlocab
Copy link
Member

See #134251.

@carlocab carlocab added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 21, 2023
@carlocab
Copy link
Member Author

Needs:

@carlocab carlocab added the CI-linux-self-hosted Build on Linux self-hosted runner label Jun 21, 2023
@carlocab
Copy link
Member Author

/home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: error: /home/linuxbrew/.linuxbrew/lib/libarrow_acero.so.1200.1.0: file too short
😕

@p-linnane p-linnane mentioned this pull request Jun 21, 2023
Closed
@Bo98
Copy link
Member

Bo98 commented Jun 21, 2023

Looks like something went wrong when building apache-arrow.

@carlocab
Copy link
Member Author

Yep. Thinking about the best way to fix it.

carlocab added a commit that referenced this pull request Jun 21, 2023
@carlocab
Revert "apache-arrow: switch to openssl@3"
2d53c08 
The bottle built from this commit is broken. See #134428.

This reverts commit 813610e.
@carlocab carlocab changed the title gdal, pdal: switch to openssl@3 apache-arrow, gdal, pdal: switch to openssl@3 Jun 21, 2023
@carlocab carlocab added the long build Set a long timeout for formula testing label Jun 21, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Merged
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 22, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 22, 2023
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-linux-large-runner [DEPRECATED] Use a large GitHub runner on Linux and removed CI-linux-self-hosted Build on Linux self-hosted runner labels Jun 22, 2023
@carlocab
Copy link
Member Author

/home/linuxbrew/.linuxbrew/opt/binutils/bin/ld: error: /home/linuxbrew/.linuxbrew/lib/libarrow_acero.so.1200.1.0: file too short
😕

Happened again despite rebuilding apache-arrow. I wonder if it's an issue with the self-hosted runner.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 22, 2023
@carlocab
Copy link
Member Author

carlocab commented Jun 22, 2023 •
edited
Loading

If we look at the just-built libarrow_acero.so, we have:

./libarrow_acero.so.1200.1.0:      ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, missing section headers at 9957704

which looks wrong, since the other libraries have something like

./libarrow.so.1200.1.0:            ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=3c013ee4f89efe46b2ba2f19cc7afb897f7a2c71, not stripped

Not really sure what's wrong with it. I've attached a tarball of libarrow_acero.so in case someone wants to take a look at it.

@kou, any chance you could take a look at this?

I wonder if this is another Patchelf bug.

@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-linux-large-runner [DEPRECATED] Use a large GitHub runner on Linux labels Jun 22, 2023
@carlocab carlocab marked this pull request as ready for review June 25, 2023 16:16
@Bo98
Copy link
Member

Bo98 commented Jun 25, 2023 •
edited
Loading

The opening 1024 bytes of the file contains the sequence 0A 23 21 28, triggering a very rare bug that will only occur with files containing that byte sequence of 0A 23 21 <regular non-space character>.

Homebrew/brew#15586

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 25, 2023
@Bo98
Copy link
Member

Bo98 commented Jun 26, 2023 •
edited
Loading

acero should hopefully work now. It will require a new brew release before the new bottle can be used by non-dev users, but that will likely happen anyway before staging is merged to master.

@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 26, 2023
@carlocab
Copy link
Member Author

Looks like that worked. Thanks @Bo98!

@carlocab carlocab added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software brew Issue may be Homebrew/brew related linux Linux is specifically affected labels Jun 26, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 26, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions
Copy link
Contributor

⚠️ Bottle publish failed. CC @carlocab

@github-actions
Copy link
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 26, 2023
@BrewTestBot BrewTestBot merged commit f31d536 into Homebrew:openssl-migration-staging Jun 26, 2023
@carlocab carlocab deleted the gdal-openssl3 branch June 26, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

@chenrui333 chenrui333 Awaiting requested review from chenrui333

Assignees
No one assigned
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing openssl-3-migration Related to switching to an OpenSSL 3 dependency ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch. workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlocab @Bo98 @kou @p-linnane @BrewTestBot