Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet: switch to openssl@3 #134587

Closed
wants to merge 3 commits into from
Closed

dotnet: switch to openssl@3 #134587

wants to merge 3 commits into from

Conversation

fel1x-developer
Copy link
Contributor

See #134251.

@github-actions github-actions bot added long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue labels Jun 22, 2023
@fel1x-developer
Copy link
Contributor Author

CI-long-timeout needed.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@p-linnane p-linnane mentioned this pull request Jun 22, 2023
Closed
@p-linnane p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jun 22, 2023
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jun 23, 2023
@fel1x-developer
Copy link
Contributor Author

fel1x-developer commented Jun 23, 2023 •
edited
Loading

Related:
#95339
dotnet/source-build#2795

Maybe this PR solved this issue: dotnet/runtime#84591

Bo98
Bo98 reviewed Jun 23, 2023
View reviewed changes
Formula/dotnet.rb Outdated
Comment on lines 5 to 8
url "https://github.com/dotnet/installer.git",
tag: "v7.0.100-rtm.22521.12",
revision: "e12b7af219b96b5e07039ea8e3e268380329d72c"
version "7.0.100"
tag: "v7.0.305",
revisoin: "98e1b6c38143f69c14ca5642ff28154a076abde6"
version "7.0.305"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source-build is only supported on 7.0.1xx.

This may change for .NET 8 but for .NET 7 it's documented here.

Copy link
Member

@Bo98 Bo98 Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could/should update this to v7.0.108 however, though I'm guessing there's already been attempts to do that.

@fel1x-developer fel1x-developer force-pushed the dotnet-openssl3 branch 2 times, most recently from bc833ad to 90f1f8a Compare June 23, 2023 23:41
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 26, 2023
@p-linnane p-linnane changed the base branch from openssl-migration-staging to master June 26, 2023 23:57
@p-linnane p-linnane removed the staging-branch-pr This pull request targets a *-staging branch. label Jun 26, 2023
@carlocab carlocab mentioned this pull request Jul 1, 2023
Closed
13 tasks
@pthariensflame
Copy link
Contributor

This may need a bump to 7.0.109?

@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 2, 2023
@github-actions github-actions bot closed this Aug 10, 2023
@fel1x-developer fel1x-developer deleted the dotnet-openssl3 branch December 25, 2023 01:37
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

Assignees
No one assigned
Labels
autosquash Automatically squash pull request commits according to Homebrew style. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fel1x-developer @pthariensflame @Bo98 @chenrui333 @p-linnane