Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify-tui: switch to openssl@3 #134594

Closed
wants to merge 1 commit into from
Closed

spotify-tui: switch to openssl@3 #134594

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Jun 22, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Closed
@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Jun 22, 2023
@cho-m
Copy link
Member

cho-m commented Jun 23, 2023

openssl-sys version (0.9.58) is too old - https://github.com/Rigellute/spotify-tui/blob/v0.25.0/Cargo.lock#L1280-L1281

There are some open PRs to try to update:

However, maintainer doesn't have time to work on project - Rigellute/spotify-tui#1000

So, seems unlikely to get support for OpenSSL 3 before cutoff date of OpenSSL 1.1 EOL.

@carlocab
Copy link
Member

It seems fine to not be able to merge this for now, since it won't have openssl@3 in its dep tree after the migration.

@cho-m
Copy link
Member

cho-m commented Jun 23, 2023 •
edited
Loading

We may want to set deprecation date to match openssl@1.1 (at least for Linux). Otherwise, I think CI will hit audit failures with openssl@1.1 deprecation.

@chenrui333 @p-linnane
spotify-tui: switch to openssl@3
86e1e96 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@p-linnane p-linnane changed the base branch from openssl-migration-staging to master June 26, 2023 23:55
@p-linnane p-linnane removed the staging-branch-pr This pull request targets a *-staging branch. label Jun 26, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 18, 2023
@github-actions github-actions bot closed this Jul 25, 2023
@chenrui333 chenrui333 deleted the spotify-tui-openssl3 branch January 22, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build failure CI fails while building the software linux Linux is specifically affected openssl-3-migration Related to switching to an OpenSSL 3 dependency rust Rust use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @cho-m @carlocab @p-linnane