Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web100clt: switch to openssl@3 #134851

Merged
merged 6 commits into from
Jul 31, 2023
Merged

web100clt: switch to openssl@3 #134851

merged 6 commits into from
Jul 31, 2023

Conversation

chenrui333
Copy link
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 24, 2023
@github-actions github-actions bot added the formula deprecated Formula deprecated label Jun 24, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 24, 2023
Closed
@github-actions github-actions bot added the missing license Formula has a missing license which should be added label Jun 24, 2023
@chenrui333
Copy link
Member Author 

  configure: error: in `/tmp/web100clt-20230624-3214-qjrf5n/ndt-3.7.0.2':
  configure: error: I2util required to build NDT

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jun 24, 2023
@chenrui333
Copy link
Member Author

rerun

@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Jun 25, 2023
@p-linnane
Copy link
Member

From the homepage:

IMPORTANT NOTICE
NDT is no longer supported because the Web100 patches to the Linux kernel will not work on modern kernels (3.x and later). A follow-on project called Web10G was never completed. This documentation remains available for historical purposes only.

@Bo98
Copy link
Member

Bo98 commented Jun 26, 2023 

configure:4087: gcc-11 -o conftest -pedantic -Wall -fno-strict-aliasing -std=gnu99 -DNDEBUG -O2 -DEXPERIMENTAL_ENABLED -DDATABASE_ENABLED   -pedantic -Wall -fno-strict-aliasing -std=gnu99 -DNDEBUG -O2 -DEXPERIMENTAL_ENABLED -DDATABASE_ENABLED   conftest.c -lI2util   >&5
/usr/bin/ld: /home/linuxbrew/.linuxbrew/lib/libI2util.a(addr.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object; recompile with -fPIE
/usr/bin/ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status
configure:4094: $? = 1

PIE is now the default. Looks like i2util needs recompiling, or if we don't want to do that then we could supply -no-pie here as a workaround for that.

@p-linnane
Copy link
Member

Should we just deprecate it instead based off the message on the homepage?

@Bo98
Copy link
Member

Bo98 commented Jun 26, 2023 •
edited
Loading

It's already deprecated.

Though if it's easy enough to hack in order to have one less OpenSSL 1.1 dependent it's probably still worth doing. If not, we've already passed the 3 month point that we can consider moving to disable.

@p-linnane
Copy link
Member

It's already deprecated.

How did I miss that 🤦‍♂️

@p-linnane p-linnane changed the base branch from openssl-migration-staging to master June 26, 2023 23:46
@p-linnane p-linnane removed the staging-branch-pr This pull request targets a *-staging branch. label Jun 26, 2023
chenrui333 and others added 2 commits June 26, 2023 17:44
@chenrui333 @p-linnane
web100clt: switch to openssl@3
35822ca 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@p-linnane
i2util: revision bump
fd971af
@carlocab carlocab mentioned this pull request Jul 1, 2023
Closed
13 tasks
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 3, 2023
@cho-m cho-m removed the build failure CI fails while building the software label Jul 3, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 25, 2023
@chenrui333 chenrui333 removed the stale No recent activity label Jul 28, 2023
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Jul 28, 2023
@chenrui333
Copy link
Member Author

Build is good now. cc @Homebrew/core

@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 30, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 31, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 31, 2023
Merged via the queue into Homebrew:master with commit 897197f Jul 31, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
@chenrui333 chenrui333 deleted the web100clt-openssl3 branch January 22, 2024 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-requeued PR has been re-added to the queue formula deprecated Formula deprecated in progress Stale bot should stay away missing license Formula has a missing license which should be added openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenrui333 @p-linnane @Bo98 @SMillerDev @BrewTestBot @cho-m