Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rizin: actually use openssl@3 on Linux #134923

Merged

Conversation

nandahkrishna
Copy link
Member

See #134251. rizin has linkage with openssl@1.1 on Linux but not macOS -- openssl@1.1 was an indirect dependency on Linux alone via libzip.

linuxbrew@8fda9e96befe:~$ brew linkage -v rizin
...
Homebrew libraries:
  ...
  /home/linuxbrew/.linuxbrew/opt/openssl@1.1/lib/libcrypto.so.1.1 (openssl@1.1)
  /home/linuxbrew/.linuxbrew/opt/openssl@1.1/lib/libssl.so.1.1 (openssl@1.1)
  ...
Indirect dependencies with linkage:
  openssl@1.1

Now that libzip has switched to openssl@3, a revision bump should hopefully fix things here.

@nandahkrishna nandahkrishna added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 25, 2023
@nandahkrishna
Copy link
Member Author

Linux:

==> brew linkage --cached rizin
...
Homebrew libraries:
  ...
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libcrypto.so.3 (openssl@3)
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libssl.so.3 (openssl@3)
  ...

@nandahkrishna nandahkrishna added the ready to merge PR can be merged once CI is green label Jun 25, 2023
@github-actions
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 25, 2023
@BrewTestBot BrewTestBot merged commit 446b76d into Homebrew:openssl-migration-staging Jun 25, 2023
@nandahkrishna nandahkrishna deleted the rizin-openssl branch June 25, 2023 07:10
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants