Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev 3.3.0 (new formula) #135038

Closed
wants to merge 1 commit into from
Closed

ddev 3.3.0 (new formula) #135038

wants to merge 1 commit into from

Conversation

swang392
Copy link

@swang392 swang392 commented Jun 26, 2023

ddev is a developer toolkit for Datadog Agent integrations. ddev can be used to test integrations, and provides an interface to manage E2E environments and maintain repositories.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 26, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333
Copy link
Member

some space issue, you can use brew style --fix xx to fix it.

@swang392 swang392 force-pushed the add-ddev branch 9 times, most recently from d04cbfe to eba6f02 Compare July 3, 2023 20:38
@swang392 swang392 force-pushed the add-ddev branch 3 times, most recently from f582331 to 885c910 Compare July 6, 2023 13:20
@swang392
Copy link
Author

swang392 commented Jul 6, 2023

@chenrui333 Hi, do you know why the CI / conclusion (pull request) workflow run is failing? Thanks!

@swang392
Copy link
Author

@chenrui333 Hi! I've been trying to investigate why the CI checks are failing but I haven't able to figure it out. Any advice or help would be really appreciated, thank you!

@swang392 swang392 force-pushed the add-ddev branch 5 times, most recently from a46b927 to f266d7b Compare July 14, 2023 19:28
@chenrui333 chenrui333 added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Jul 15, 2023
@chenrui333
Copy link
Member

let me check in my local.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 15, 2023
@chenrui333 chenrui333 force-pushed the add-ddev branch 2 times, most recently from 0dc1779 to e77f33e Compare July 15, 2023 22:28
@chenrui333
Copy link
Member

@chenrui333 I'm not sure how those got derived. My process for adding dependencies was to go through each resource and add any of its dependencies to the bottom of the file, and keep going down the list until I didn't have any more new resources to add. Is there any reason why you listed those 4 dependencies? Do you know if they are unnecessary?

oh you dont have to, you can just use:

  • setup python3.11 virtualenv
  • pip install ddev
  • pip freeze to get the full dependency list
  • and then you use homebrew-pypi-poet to get the full list for the formula

that is how I am doing it

@swang392
Copy link
Author

@chenrui333 Gotcha, I just did that and updated the formula -- now I am seeing the memray issue that you mentioned above.

@chenrui333
Copy link
Member

memray issue seems resolved, bloomberg/memray#426 (comment)

Gonna refresh this PR and have another run.

@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 28, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 28, 2023
@chenrui333
Copy link
Member

ModuleNotFoundError: No module named 'black' looks like path issue

@chenrui333 chenrui333 changed the title ddev 3.1.0 (new formula) ddev 3.3.0 (new formula) Jul 28, 2023
@chenrui333
Copy link
Member

have some issue building hatching-1.18.0 locally

        ERROR: Could not find a version that satisfies the requirement setuptools>=45.0 (from versions: none)
        ERROR: No matching distribution found for setuptools>=45.0

@chenrui333 chenrui333 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-requeued PR has been re-added to the queue labels Jul 31, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 31, 2023
@swang392
Copy link
Author

@chenrui333 could you add the CI-long-timeout tag? I was able to install and test locally.

@swang392
Copy link
Author

swang392 commented Aug 4, 2023

@chenrui333 Just wanted to bump this!

@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 4, 2023
@chenrui333
Copy link
Member

rerunning 🤞

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 4, 2023
@swang392
Copy link
Author

swang392 commented Aug 4, 2023

@chenrui333 I fixed the Linux error, but I am getting a ModuleNotFoundError: No module named 'black'error on all of the MacOS CI checks even though I have added a dependency statement for the black module. I was looking at some of the other formulas in the repository -- do I need to add something like the lines below?

black = Formula["black"].opt_libexec
(libexec/site_packages/"homebrew-black.pth").write black/site_packages

@chenrui333
Copy link
Member

yeah, we need to have that, can't we reproduce the CI error in the local?

add ddev as new formula

ddev: use memray 1.9.0

Signed-off-by: Rui Chen <rui@chenrui.dev>

ddev: update deps and pypi_formula_mappings.json

Signed-off-by: Rui Chen <rui@chenrui.dev>
@swang392
Copy link
Author

swang392 commented Aug 8, 2023

@chenrui333 I added it in! I was not getting any of these errors on my local computer even though I have a mac. Is there a way to match the environment to get the same results?
I tried to do brew install with the new clause for black but I got an error saying undefined local variable or method 'site_packages' but I see other homebrew formulas with it. Would you be able to add the tag back?

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 30, 2023
@github-actions github-actions bot closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants