Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metashell 5.0.0 #138798

Closed
wants to merge 1 commit into from
Closed

metashell 5.0.0 #138798

wants to merge 1 commit into from

Conversation

Porkepix
Copy link
Contributor

@Porkepix Porkepix commented Aug 6, 2023

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added deprecated license Formula uses a deprecated SPDX license which should be updated bump-formula-pr PR was created using `brew bump-formula-pr` labels Aug 6, 2023
@chenrui333
Copy link
Member 

  CMake Error at /home/linuxbrew/.linuxbrew/Cellar/cmake/3.27.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter) (Required
    is at least version "3.6")

@chenrui333 chenrui333 added the build failure CI fails while building the software label Aug 6, 2023
@iMichka iMichka force-pushed the bump-metashell-5.0.0 branch from d38190c to 69943e4 Compare August 6, 2023 14:35
@iMichka
Copy link
Member

iMichka commented Aug 6, 2023

Let's try with the change I made previously: #128202
We were waiting for this release to see if we can build a Ventura bottle too.

@iMichka iMichka removed the build failure CI fails while building the software label Aug 6, 2023
@iMichka iMichka force-pushed the bump-metashell-5.0.0 branch from 69943e4 to f2be3a9 Compare August 6, 2023 14:37
@github-actions github-actions bot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Aug 6, 2023
@iMichka iMichka mentioned this pull request Aug 6, 2023
Closed
@chenrui333
Copy link
Member

make: *** No rule to make target `templight'. Stop.

@chenrui333 chenrui333 added license License PRs build failure CI fails while building the software labels Aug 6, 2023
@chenrui333 chenrui333 force-pushed the bump-metashell-5.0.0 branch from f2be3a9 to deea604 Compare August 6, 2023 21:02
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed build failure CI fails while building the software labels Aug 6, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 7, 2023
@chenrui333
Copy link
Member

linux test failure.

@iMichka
Copy link
Member

iMichka commented Aug 7, 2023

==> /home/linuxbrew/.linuxbrew/Cellar/metashell/5.0.0/bin/metashell -H
Error: Clang binary not found.
Error: metashell: failed
An exception occurred within a child process:
Minitest::Assertion: Expected /const\ int/ to match "clang++ not found.

I think we are almost there to get this shipped. @sabel83 might have an idea.
Looks like it's not finding clang on Linux. I was under the impression that I installed its own clang? Or is clang provided by homebrew maybe now necessary at runtime?

@iMichka iMichka mentioned this pull request Aug 7, 2023
Closed
@chenrui333 chenrui333 mentioned this pull request Aug 8, 2023
Merged
6 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 10, 2023
sabel83
sabel83 reviewed Aug 10, 2023
View reviewed changes
Formula/metashell.rb Outdated
system "cmake", "../llvm", "-DLLVM_ENABLE_TERMINFO=OFF", *std_cmake_args
system "make", "templight"
end
system "cmake", "-S", "3rd/templight/llvm", "-B", "llvm_build", "-DLLVM_ENABLE_TERMINFO=OFF", *std_cmake_args
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing the build directory of templight (the clang build shipped with metashell). Metashell's own build scripts are sensitive to the location of the templight builds, which is likely to be the reason for the error you get from the CI. Take a look at CMakeLists.txt in the root of Metashell's source tree and cmake/Modules/FindTemplight.cmake for more details.

@sabel83
Copy link

sabel83 commented Aug 10, 2023

==> /home/linuxbrew/.linuxbrew/Cellar/metashell/5.0.0/bin/metashell -H
Error: Clang binary not found.
Error: metashell: failed
An exception occurred within a child process:
Minitest::Assertion: Expected /const\ int/ to match "clang++ not found.

I think we are almost there to get this shipped. @sabel83 might have an idea. Looks like it's not finding clang on Linux. I was under the impression that I installed its own clang? Or is clang provided by homebrew maybe now necessary at runtime?

Metashell comes with a special clang, you don't need to install another one for it. Take a look at my comment about the build location.

@github-actions github-actions bot removed the stale No recent activity label Aug 10, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 13, 2023
@iMichka iMichka force-pushed the bump-metashell-5.0.0 branch from deea604 to 7e88744 Compare August 13, 2023 13:15
@iMichka iMichka added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed stale No recent activity labels Aug 13, 2023
@Porkepix @iMichka
metashell 5.0.0
c0362b3 
metashell: update build

Signed-off-by: Rui Chen <rui@chenrui.dev>
@iMichka iMichka force-pushed the bump-metashell-5.0.0 branch from 7e88744 to c0362b3 Compare August 14, 2023 18:52
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 14, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 17, 2023
@github-actions github-actions bot closed this Aug 18, 2023
@iMichka
Copy link
Member

iMichka commented Aug 25, 2023

Follow up PR: #140453
Found the issue, we forgot "-DLLVM_ENABLE_PROJECTS=clang"

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sabel83 sabel83 sabel83 left review comments

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. license License PRs long build Set a long timeout for formula testing outdated PR was locked due to age stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Porkepix @chenrui333 @iMichka @sabel83