Build V8 with libcxx instead of libstdc++, fixes #14230

[jeroen]

See #14230 for details.

V8 3.15 uses an old version of gyp to build, which defaults to the legacy libstdc++. This leads to compatibility problems with applications build with clang + libcxx (default on Mavericks and up).

By setting -mmacosx-version-min=10.9 clang will build against the libcxx instead.

[DomT4]

Be surprised if simply copying this doesn't work fine.

[jeroen]

@DomT4 I guess that would work as well. Would you prefer that?

[DomT4]

I'm no longer a maintainer here so it's not my call ultimately, but that's tried & tested, and more brewish than hardcoding in one specific version of macOS that may not align with the system the user is running.

[jeroen]

Right, either way works fine probably. Who is the new maintainer of this formula?

[DomT4]

Individual formulae do not have specific maintainers, in theory. @ilovezfs runs homebrew/core these days, choice is on him.

[jeroen]

OK I'll wait for @ilovezfs to respond if he is OK with the current solution or not.

[jeroen]

@ilovezfs ping, does this look OK to merge?

[ilovezfs]

@jeroen do you mind testing if the lines @DomT4 linked to work as well?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[jeroen]

@ilovezfs sorry for the delay. I have now changed the commit to do what you suggested and use the same lines from the v8 formula to fix the same problem.

[ilovezfs]

@jeroen no worries. And I assume you've tested it works as expected?

[jeroen]

Yes I build locally and it seems to fix the problem.

[DomT4]

Theoretically you'll want the needs :cxx11 as well, for the folks who have ancient compilers installed.

[jeroen]

I think the library builds fine without CXX11, it just has to use libcxx...

[jeroen]

I think this is good to go?

[jeroen]

Ping? Anything else we need to change?

[ilovezfs]

@BrewTestBot test this please

[jeroen]

Looking good: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/4893/

[ilovezfs]

Thanks @jeroen! Shipped :)