Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.18.0 #14375

Closed
wants to merge 2 commits into from
Closed

rust 1.18.0 #14375

wants to merge 2 commits into from

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 8, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ilovezfs
Copy link
Contributor

ilovezfs commented Jun 8, 2017

@alexcrichton for cargo is it correct to build the latest tag (0.19.0) to pair with 1.18.0? And should we be bootstrapping cargo from

https://static.rust-lang.org/dist/2017-04-27/cargo-nightly-x86_64-apple-darwin.tar.gz

or from something else?

(It looks like https://github.com/rust-lang/rust/blob/1.18.0/src/stage0.txt no longer records the revision so I assume we're back to the nightly with the same date?)

Copy link
Contributor

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get cargo bootstrap updated to whatever it should be now.

@ilovezfs
Copy link
Contributor

@JCount thinks the correct cargo bootstrap URL is now

https://static.rust-lang.org/dist/2017-04-27/cargo-0.18.0-x86_64-apple-darwin.tar.gz

based on

https://github.com/rust-lang/rust/blob/1.18.0/src/bootstrap/bootstrap.py#L204

@ilovezfs ilovezfs closed this in 762177e Jun 10, 2017
@ilovezfs
Copy link
Contributor

Thanks @alex! Shipped 🚀

@alexcrichton
Copy link
Contributor

Looks good to me!

@alex alex deleted the patch-1 branch June 18, 2017 21:35
@alex
Copy link
Contributor Author

alex commented Jun 18, 2017

Thanks for dragging this over the finish line, I was off the grid for a bit :)

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants