rust: Fix rustlib dylib IDs in post_install. #14490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the less invasive version of Homebrew/brew#2764.
5 tasks
ilovezfs
reviewed
Jun 12, 2017
Formula/rust.rb
Outdated
| @@ -101,6 +102,13 @@ def install | |||
| rm_rf prefix/"lib/rustlib/install.log" | |||
| end | |||
|
|
|||
| def post_install | |||
| Dir["#{lib}/rustlib/**/*.dylib"].each do |dylib| | |||
| chmod 0755, dylib | |||
There was a problem hiding this comment.
Should we restore the permissions after the change?
There was a problem hiding this comment.
I don't see any particular harm in leaving them like this, although it might be good to change them back from a consistency standpoint.
ilovezfs
added
rust
ilovezfs
approved these changes
Jun 12, 2017
ilovezfs
pushed a commit
that referenced
this pull request
Jun 12, 2017
This is the less invasive version of Homebrew/brew#2764. Closes #14490. Signed-off-by: ilovezfs <ilovezfs@icloud.com>
|
Shipped. 🙈 ✅ |
This was referenced Jun 12, 2017
Closed
mriehl
added a commit
to brocode/fw
that referenced
this pull request
Jun 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the less invasive version of Homebrew/brew#2764.
See rust-lang/rust#39870.
cc @ilovezfs, @MikeMcQuaid
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?