Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang@25: Workaround for Mac OS Sonoma #146279

Closed

Conversation

rafaelgaspar
Copy link

@rafaelgaspar rafaelgaspar commented Sep 27, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This basically disables JIT compiling for now since the way erlang@25 does JIT compiling is not supported by Mac OS Sonoma.

See this for more information: erlang/otp#7687

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. legacy Relates to a versioned @ formula labels Sep 27, 2023
@rafaelgaspar rafaelgaspar changed the title Workaround for Erlang@25 on Mac OS Sonoma Workaround for erlang@25 on Mac OS Sonoma Sep 27, 2023
@rafaelgaspar rafaelgaspar changed the title Workaround for erlang@25 on Mac OS Sonoma erlang@25: Workaround for Mac OS Sonoma Sep 27, 2023
@rafaelgaspar rafaelgaspar force-pushed the fix-erlang25-mac-os-sonoma branch from 82fb9fb to 48d06c8 Compare September 27, 2023 12:55
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 27, 2023
@rafaelgaspar rafaelgaspar marked this pull request as ready for review September 27, 2023 12:56
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@rafaelgaspar rafaelgaspar force-pushed the fix-erlang25-mac-os-sonoma branch from 48d06c8 to 6810e8a Compare September 27, 2023 13:54
This basically disables JIT compiling for now since the way erlang@25 does JIT compiling is not supported by Mac OS Sonoma.

See this for more information: erlang/otp#7687
@rafaelgaspar rafaelgaspar marked this pull request as draft September 27, 2023 15:19
@rafaelgaspar
Copy link
Author

Not really sure how to fix the documentation issues happening on Mac OS 12.

@rafaelgaspar rafaelgaspar force-pushed the fix-erlang25-mac-os-sonoma branch from 6810e8a to 362b3a6 Compare September 27, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Relates to a versioned @ formula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant