pypi_formula_mappings: extra_packages for python@X #153077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@yossarian.net>
github-actions
bot
added
the
automerge-skip
|
CC @chenrui333 for opinions 🙂 |
chenrui333
reviewed
Nov 1, 2023
pypi_formula_mappings.json
Outdated
Comment on lines
847
to
864
| "python@3.7": { | ||
| "extra_packages": ["setuptools", "pip", "wheel"] | ||
| }, | ||
| "python@3.8": { | ||
| "extra_packages": ["setuptools", "pip", "wheel"] | ||
| }, | ||
| "python@3.9": { | ||
| "extra_packages": ["setuptools", "pip", "wheel"] | ||
| }, | ||
| "python@3.10": { | ||
| "extra_packages": ["setuptools", "pip", "wheel"] | ||
| }, | ||
| "python@3.11": { | ||
| "extra_packages": ["setuptools", "pip", "wheel"] | ||
| }, | ||
| "python@3.12": { | ||
| "extra_packages": ["setuptools", "pip", "wheel"] | ||
| }, |
There was a problem hiding this comment.
We can also leave out 3.7 since it's end of life and disabled.
There was a problem hiding this comment.
you also need
flit-core
I saw that in some of the versions but not others; do you know where it came from? AFAICT Python itself doesn't use flit-core anywhere in its build.
There was a problem hiding this comment.
@woodruffw there is come context in this thread:
chenrui333
added
the
CI-syntax-only
chenrui333
reviewed
Nov 1, 2023
Signed-off-by: William Woodruff <william@yossarian.net>
|
Added |
chenrui333
approved these changes
Nov 1, 2023
|
@woodruffw 3.8 does not need |
Not needed. Signed-off-by: William Woodruff <william@yossarian.net>
Dropped, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I'm not 100% confident that this is the "right" way to do things, but this should address cases like #153070 and #153069 -- when
python@Xis bumped these resources appear to be required, so we mark them as such in the PyPI formula mapping.