Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.26.1 #154294

Merged
merged 2 commits into from
Nov 14, 2023
Merged

dolt 1.26.1 #154294

merged 2 commits into from
Nov 14, 2023

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 7003: Print an error when server args don't validate
    We aren't printing any errors from sql-server when there are unparsable flags.
    Previous Behavior:
    $ dolt sql-server --rasdjdsdlsdk
    $ echo $?
    1
    
    New Behavior:
    $ dolt sql-server --rasdjdsdlsdk
    error: sql-server does not take positional arguments, but found 1: asdjdsdlsdk
    $ echo $?
    1
    
  • 6996: go: sqle: cluster: commithook: When shutting down the server, the cluster replication commithook could deadlock after the replication thread missed a wakeup signal.
    Fix it so that the wakeup thread is guaranteed to see the canceled context or the wakeup signal.
  • 6992: go/libraries/doltcore/remotesrv: Ensure we stop the gRPC server and cancel inflight requests when we are multiplexing one port for HTTP and gRPC traffic.
  • 6977: Improve the persistence of the file that stores USERs and GRANTs.
    The USERs and GRANTs on a sql-server instance are stored in a separate file from the Merkle DAG table data that makes up the Dolt databases themselves. Previously, the contents of this file were not written in a crash resistant way, and they could be lost or corrupted after a crash or when taking a block-device snapshot.
    This change also changes the file's permission bits to be 0600, instead of 0777, which was much more permissive than intended.
  • 6974: Support merging schemas with virtual / generated columns
    Substantially addresses virtual column merges don't work dolthub/dolt#6945, although there are a couple remaining edge cases that are hard to crack, in this PR as skipped tests.

go-mysql-server

  • 2144: Push filters insensitive to table name
    Filter pushing bug that is specific to 1) table names with capital letters, and 2) filters that need to move through joins. The problem is not indexing specifically, but checking for an index is the easiest way to test this.
    dolt bump: [no-release-notes] GMS bump for filter push bug dolthub/dolt#7001
  • 2142: Idx histogram manipulation
    Add simple histogram mutators for filter types. Use histogram costs for index selection when available. Added stats docs.
    Dolt enginetests seem to be passing. Companion here: [no-release-notes]Stats bump dolthub/dolt#6997
    TODO:
    • I'd like to block statistics when only partially provided
    • TPCC plans are changed and I want to revert. Blocking partial statistics might fix those, I'm trying to get all of the actual index statistics for those tables as a better enginetest/blog example.
  • 2141: Fixing field metadata for JSON and geometry types
    JSON and geometry types should always report a binary collation in MySQL's field metadata. While debugging Regression: Pasting into Datagrip TEXT field puts null dolthub/dolt#6970, I noticed that MySQL was sending a binary collation for these types, but GMS was sending back the default collation.
  • 2140: Respect character_set_results when emitting field metadata
    For non-binary types, we need to respect the value for the character_set_results session var (when not NULL) and use that for the field metadata returned in the MySQL wire protocol.
    The unexpected charset/collation metadata is causing DataGrip to be unable to work with some types in the table editor ( see Regression: Pasting into Datagrip TEXT field puts null dolthub/dolt#6970 for more details).
    I've validated this behavior with MySQL by inspecting packets with Wireshark. For testing, we were already testing the behavior of character_set_results and the charset translation, but we weren't testing the field metadata. I added support to check against the expect charset field metadata, but had to use reflection to get that data from the MySQL driver, since it's not exposed through the standard golang sql database APIs.
  • 2135: Resolve indexes of columns in CREATE TABLE statements early

Closed Issues

  • 6945: virtual column merges don't work
  • 6970: Regression: Pasting into Datagrip TEXT field puts null

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Nov 14, 2023
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 14, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 14, 2023
Merged via the queue into Homebrew:master with commit 3cc2e26 Nov 14, 2023
12 of 13 checks passed
@BrewTestBot BrewTestBot deleted the bump-dolt-1.26.1 branch November 14, 2023 18:59
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants