Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
We aren't printing any errors from sql-server when there are unparsable flags.
Previous Behavior:
Fix it so that the wakeup thread is guaranteed to see the canceled context or the wakeup signal.
The USERs and GRANTs on a sql-server instance are stored in a separate file from the Merkle DAG table data that makes up the Dolt databases themselves. Previously, the contents of this file were not written in a crash resistant way, and they could be lost or corrupted after a crash or when taking a block-device snapshot.
This change also changes the file's permission bits to be
0600
, instead of0777
, which was much more permissive than intended.Substantially addresses virtual column merges don't work dolthub/dolt#6945, although there are a couple remaining edge cases that are hard to crack, in this PR as skipped tests.
go-mysql-server
Filter pushing bug that is specific to 1) table names with capital letters, and 2) filters that need to move through joins. The problem is not indexing specifically, but checking for an index is the easiest way to test this.
dolt bump: [no-release-notes] GMS bump for filter push bug dolthub/dolt#7001
Add simple histogram mutators for filter types. Use histogram costs for index selection when available. Added
stats
docs.Dolt enginetests seem to be passing. Companion here: [no-release-notes]Stats bump dolthub/dolt#6997
TODO:
JSON
andgeometry
typesJSON
andgeometry
types should always report a binary collation in MySQL's field metadata. While debugging Regression: Pasting into Datagrip TEXT field puts null dolthub/dolt#6970, I noticed that MySQL was sending a binary collation for these types, but GMS was sending back the default collation.character_set_results
when emitting field metadataFor non-binary types, we need to respect the value for the
character_set_results
session var (when notNULL
) and use that for the field metadata returned in the MySQL wire protocol.The unexpected charset/collation metadata is causing DataGrip to be unable to work with some types in the table editor ( see Regression: Pasting into Datagrip TEXT field puts null dolthub/dolt#6970 for more details).
I've validated this behavior with MySQL by inspecting packets with Wireshark. For testing, we were already testing the behavior of
character_set_results
and the charset translation, but we weren't testing the field metadata. I added support to check against the expect charset field metadata, but had to use reflection to get that data from the MySQL driver, since it's not exposed through the standard golang sql database APIs.Closed Issues