qemu: revert "update EFI image to fix an issue on Apple M3" #155469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
autosquash
chenrui333
previously approved these changes
Nov 25, 2023
AkihiroSuda
force-pushed
the
revert-155388
branch
from
c41f793
to
65b7403
Compare
chenrui333
changed the title
github-actions
bot
removed
the
autosquash
This reverts commit 0789e7a. It was reported that the fix for M3 breaks M1: https://gitlab.com/qemu-project/qemu/-/issues/1990#note_1666099003 Revert PR 155388 (155419). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
revert-155388
branch
from
65b7403
to
d7415c3
Compare
5 tasks
chenrui333
previously approved these changes
Nov 25, 2023
|
⛔ It looks like @BrewTestBot cannot push to your PR branch. For future pull requests, please allow maintainers to edit your PR to simplify the merge process. |
github-actions
bot
added
the
no push access
|
🤖 An automated task has requested creation of a replacement PR. |
github-actions
bot
dismissed stale reviews from chenrui333 and chenrui333
Replacement PR dispatched
github-actions
bot
added
automerge-skip
|
✅ Replacement PR created at #155476. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2023
Replacement for #155469
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0789e7a.
It was reported that the fix for M3 breaks M1:
https://gitlab.com/qemu-project/qemu/-/issues/1990#note_1666099003
Revert:
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?