Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broot: move bash completions to bash-completion@2 path #156448

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 5, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Dec 5, 2023
@cho-m
Copy link
Member Author

cho-m commented Dec 5, 2023

If clap decides to add support for Bash 3 (clap-rs/clap#5190) then may move completions back. In mean time, all Rust formulae Bash completions will probably not work.

@cho-m cho-m force-pushed the broot-move-completions branch from e42f91a to 1797e43 Compare December 5, 2023 16:50
@cho-m cho-m force-pushed the broot-move-completions branch from 1797e43 to ae0dd1e Compare December 5, 2023 16:57
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 5, 2023
@BrewTestBot BrewTestBot enabled auto-merge December 5, 2023 18:22
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 5, 2023
Merged via the queue into Homebrew:master with commit fc3c033 Dec 5, 2023
12 checks passed
@cho-m cho-m deleted the broot-move-completions branch December 10, 2023 20:49
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants