consul: fix to remove outdated caveat #15926
Conversation
|
Should we also remove in that case? |
|
@ilovezfs I'll do some tests to make sure that's correct and update this shortly if that's valid/or not. |
The caveat for the `-ui-dir` parameter is no longer correct as since 0.7
and above produce this warning if you try and use it:
```
==> If using Consul version 0.7.0 or later, the web UI is included in the
binary so use ui to enable it
```
Using -agent -dev implies -ui and so the caveat produces an error trying
to start Consul.
As a result the `pkgshare.install` is superfluous and so that's gone
too.
|
Amended to remove the |
|
@leepa is this going to be a problem, though: hashicorp/consul#3292 (comment) |
|
Depends if one wants to locally customise - which I'd recommend against doing in that folder as it'll be overwritten by a subsequent install, surely? Is it better for the user to download and customise the theme outside of /usr/local? |
|
@leepa I guess we should just remove it, since that particular case will be fixed in the next release anyway. |
|
I believe the priority, in this case, is to ensure that users aren't confused by the caveat when they inevitably upgrade. Whatever happens in the Consul project it'll need new guidance once they've fixed the issue, so I believe the current state is correct. Let me know if there's anything else I need to do. |
|
Nope, shipped! Thanks for the PR. |
The caveat for the
-ui-dirparameter is no longer correct as since 0.7and above produce this warning if you try and use it:
Using -agent -dev implies -ui and so the caveat produces an error trying
to start Consul.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?