Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgvector: restore postgresql@14 #159723

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Jan 12, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Expands #159695 to postgresql@14

Earlier versions would need something similar to #159557 to work

@ankane ankane force-pushed the pgvector-postgresql-14 branch 2 times, most recently from ba2be4e to 966857f Compare January 12, 2024 01:10
@chenrui333 chenrui333 requested a review from cho-m January 12, 2024 01:59
@ankane ankane force-pushed the pgvector-postgresql-14 branch from 966857f to 3f3527a Compare January 12, 2024 18:48
@ankane ankane changed the title pgvector: add postgresql@14 pgvector: restore postgresql@14 Jan 12, 2024
@ankane
Copy link
Contributor Author

ankane commented Jan 12, 2024

It looks like #159557 was reverted, so updated the PR to restore postgresql@14 (as the formula is currently broken).

@chenrui333
Copy link
Member

It looks like #159557 was reverted, so updated the PR to restore postgresql@14 (as the formula is currently broken).

yeah, there was some pg issue and we reverted the update.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 15, 2024
@BrewTestBot BrewTestBot enabled auto-merge January 15, 2024 19:51
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 15, 2024
Merged via the queue into Homebrew:master with commit 39d0d7d Jan 15, 2024
12 checks passed
@ankane
Copy link
Contributor Author

ankane commented Jan 15, 2024

Thanks @chenrui333!

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants