-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libxmlsec1@1.2 1.2.39 (new formula) #161079
Conversation
34e8f71
to
3ea710a
Compare
python-xmlsec seems to not be updated anymore so we would effectively be maintaining this forever which seems undesirable. |
The situation with In the meantime there are brew users implementing various differnt workarounds that are only likely to cause further trouble by building the last available 1.2.x I would expect the important thing to brew is that libxmlsec1 1.2 is still maintained upstream. |
I mean it's been a year, that's already a lot longer than what other formulae get.
This however is the better argument to take. We have a policy for what versioned formulae to allow (https://docs.brew.sh/Versions) and it being maintained upstream means that this would be acceptable to add. So I'm OK with adding this based on that information. That also gives us a rough idea of how long to maintain it. When upstream stops updating 1.2 then we can deprecate the formula. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I work for a ~100 engineers company and I can confirm there is a significant interest for this recipe to be merged. We have to use python-xmlsec because of python3-saml and it's currently utterly broken at python dependencies installation time in one of the least understandable manner even for seasoned developers, it would be such an incredible developer experience improvement for this one to be merged. |
That isn't impactful to Homebrew as a project unless that company is maintaining the software. If your company needs a certain piece of software a private tap is the way to go. Let's keep this discussion to if it should be in homebrew/core or not based on our policies and the maintenance burden involved. |
Can someone ask how long they are planning to maintain it? That way we can already set a deprecation/disable policy. |
I asked the question there discussion #762, and there answer is:
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Activity has resumed on python-xmlsec. Most PRs fixing the problems have been merged. A release hasn't been done yet but I bet it will be done in a not-so-long-time. |
@SMillerDev so, what's your take on this? |
I'm not sure why a formula is needed if the fixes exist and are merged for 1.3 compatibility. |
ack. hopefully a new |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?python-xmlsec
is not compatible with currentlibxmlsec1
1.3, add a parallel-installablelibxmlsec1@1.2
that can be used with python xmlsec: